'loading.gif' is found in many different places: standardize it in one location!

RESOLVED FIXED in seamonkey2.0b1

Status

SeaMonkey
Themes
RESOLVED FIXED
14 years ago
9 years ago

People

(Reporter: Alfred Kayser, Assigned: sgautherie)

Tracking

Trunk
seamonkey2.0b1
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

14 years ago
In the 'Classic' and 'Modern' themes, the image loading.gif is all over the place:

[code]
/themes/classic/communicator/bookmarks/bookmarks.css, line 67 --
list-style-image: url("chrome://global/skin/loading.gif") !important;
/themes/classic/communicator/directory/directory.css, line 65 --
list-style-image: url("chrome://communicator/skin/icons/loading.gif");
/themes/classic/communicator/related/related.css, line 76 -- list-style-image:
url("chrome://global/skin/loading.gif") ! important ;
/themes/classic/communicator/search/search.css, line 45 -- list-style-image:
url("chrome://communicator/skin/icons/loading.gif");
/themes/classic/communicator/sidebar/sidebar.css, line 111 -- list-style-image:
url("chrome://communicator/skin/icons/loading.gif");
/themes/classic/global/mac/browser.css, line 36 -- list-style-image:
url("chrome://communicator/skin/icons/loading.gif");
/themes/classic/global/win/browser.css, line 32 -- list-style-image:
url("chrome://communicator/skin/icons/loading.gif");
/themes/modern/communicator/bookmarks/bookmarks.css, line 69 --
list-style-image: url("chrome://global/skin/loading.gif") !important;
/themes/modern/communicator/directory/directory.css, line 65 --
list-style-image: url("chrome://communicator/skin/icons/loading.gif");
/themes/modern/communicator/related/related.css, line 69 -- list-style-image:
url("chrome://communicator/skin/icons/loading.gif") !important ;
/themes/modern/communicator/search/search.css, line 45 -- list-style-image:
url("chrome://communicator/skin/icons/loading.gif");
/themes/modern/communicator/sidebar/sidebar.css, line 113 -- list-style-image:
url("chrome://communicator/skin/icons/loading.gif");
/themes/modern/global/browser.css, line 62 -- list-style-image:
url("chrome://communicator/skin/icons/loading.gif");
/toolkit/components/help/skin/help.css, line 130 -- list-style-image:
url("chrome://global/skin/icons/Loading.gif");
/toolkit/skin/win/browser.css, line 32 -- list-style-image:
url("chrome://global/skin/icons/Loading.gif");
/browser/base/skin/browser.css, line 713 -- list-style-image:
url("chrome://global/skin/icons/Loading.gif");
/browser/base/skin/browser.css, line 746 -- list-style-image:
url(chrome://global/skin/icons/Loading.gif);[/code]

Luckely the only references are in the in '/skin' part, so all changeable by the
themer.

Can we move 'loading.gif" to just '/global/skin/' (or /global/skin/icons/ if
really needed)?

If they are semantically different than use also a really distinguishing name...

Comment 1

14 years ago
Well, toolkit doesn't have communicator/ so it needs to stuff everything into
global/ and so the only issue is that bookmarks and related weren't fixed when
hewitt moved loading.gif from global into communicator.

Or alternatively we could just move loading.gif back into global...
(Reporter)

Comment 2

14 years ago
That's indeed what should happen as a lot of components using loading.gif,
so it is pretty general, so /global/skin is a good place for it.
Product: Core → SeaMonkey
(Assignee)

Comment 3

9 years ago
Created attachment 372279 [details] [diff] [review]
(Av1) <bookmarks.css>
[Checkin: Comment 6]

I don't know what the situation was in 2004,
but fixing this missed reference seems enough now.

Yet, tell me if this file should actually be moved back to "global"...
Assignee: themes → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #372279 - Flags: review?(neil)
(Assignee)

Comment 4

9 years ago
The image file lives in
http://mxr.mozilla.org/comm-central/find?text=&kind=text&string=%2Floading.gif
Flags: in-testsuite-
QA Contact: themes
Summary: 'loading.gif' is found in many different places: standardise it one location! → 'loading.gif' is found in many different places: standardize it one location!
Target Milestone: --- → seamonkey2.0b1
(Assignee)

Updated

9 years ago
Summary: 'loading.gif' is found in many different places: standardize it one location! → 'loading.gif' is found in many different places: standardize it in one location!

Comment 5

9 years ago
That icon will look odd for mac classic, but I guess I can take care of that in bug 460699.

Updated

9 years ago
Attachment #372279 - Flags: review?(neil) → review+
(Assignee)

Comment 6

9 years ago
Comment on attachment 372279 [details] [diff] [review]
(Av1) <bookmarks.css>
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/2dd61877111c
Attachment #372279 - Attachment description: (Av1) <bookmarks.css> → (Av1) <bookmarks.css> [Checkin: Comment 6]
(Assignee)

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.