245043 - Installing multiple extensions via InstallTrigger.install() fails

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[PikeUK]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040529 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040529 Firefox/0.8.0+

When more than one extension is installed via an InstallTrigger only some of
them install. Initially they all display in the Extension Manager but one by one
they disappear until only a few are left.

Reproducible: Sometimes
Steps to Reproduce:
1. Visit the URL (or see the attachment in the next comment for a testcase)
2. Click "All" then "Install Extensions"
3. When the Software Install box appears click "Install"

Actual Results:  
Only some of the extensions were installed

Expected Results:  
All of the extensions should have been installed

Sorry if this is not a front end bug.

Comment 1

[PikeUK]

Attachment: InstallTrigger testcase using Ben Goodger's test extensions

Steps to Reproduce:
1. Load the attachment
2 [details] [diff] [review]. Press "Install"
3. When the Software Install box appears click "Install"

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Bypass the cache by extracting install.rdf to a salted file name.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

(What was happening was that for each extension the install manifest install.rdf
was being extracted to a temp dir correctly, but GetDataSourceBlocking was
returning a cached version of the first one in the queue, meaning that only one
extension would ever show up in the list) 

Fixed on the branch. Will be fixed on trunk when EM is enabled fully there.