245055 - assert on print due to caret code [###!!! ASSERTION: bulletproofing, see bug #24329: 'returnView', file nsCaret.cpp]

Status: RESOLVED WORKSFORME

(Core :: Printing: Output, defect)

Description

[(not reading, please use [e-mail] instead)]

assert on print (used to crash) due to caret code.

from roc's comments in bug #243294:

"The best fix would be to never mess with the caret while printing, since that
makes no sense....the very best fix of all would be to rip out this caret crap
and draw the caret as part of the normal frame painting code."

Comment 1

[(not reading, please use [e-mail] instead)]

see bug #243294 for details on how to reproduce this assert.

###!!! ASSERTION: bulletproofing, see bug #24329: 'returnView', file c:/mozilla/
trees/netscape72/mozilla/layout/base/src/nsCaret.cpp, line 832

Comment 2

[Uri Bernstein]

Making this depend on bug 287813, based on comment #0.

Comment 3

[Martijn Wargers (dead)]

Is this still an issue now that bug 287813 is fixed?

Comment 4

[(not reading, please use [e-mail] instead)]

> see bug #243294 for details on how to reproduce this assert.

I'll test and see if I still assert.

The code is still in there, see http://lxr.mozilla.org/mozilla1.8/source/layout/base/nsCaret.cpp#813

NS_ASSERTION(returnView, "bulletproofing, see bug #24329");

Comment 5

[:Cykesiopka]

The assertion was removed as part of Bug 287813.

(See http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/layout/base&command=DIFF_FRAMESET&file=nsCaret.cpp&rev1=1.154&rev2=1.155&root=/cvsroot )