245109 - Do not try to remove a file that does not exist - Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFile.remove]"

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[timeless]

steps:
1. build firefox
2. run firefox
3. read console

actual output:
*** eeeeeeee = [Exception... "Component returned failure code: 0x80520012
(NS_ERROR_FILE_NOT_FOUND) [nsIFile.remove]"  nsresult: "0x80520012
(NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame ::
file:///Users/timeless/opt-powerpc-apple-darwin7.4.0-firebird/dist/Firefox.app/Contents/MacOS/components/nsExtensionManager.js
:: ensureExtensionsFiles :: line 217"  data: no]

expected output:
none.

this has been reported in
		bugzilla-daemon (3)	 	Inbox [Bug 244668] [trunk] Profile Manager broken in OS
X  - http://bugzilla.mozilla.org/show_bug.cgi?id=244668 - Additional Comments
From risc …	 	May 29
		bugzilla-daemon (8)	 	Inbox [Bug 243315] Official Firefox Linux GTK2+Xft
builds do no... - http://bugzilla.mozilla.org/show_bug.cgi?id=243315
[e-mail] changed: What |Removed …	 	May 19

Resolution:
stash the GetFile result, check to see that the file exists and only delete it
if it does.

Comment 1

[Iain MacDonnell]

This isn't Mac-specific, but I'm apparently not empowered-enough to edit that.

Also, it's kindof ugly, so I think it should fixed before 1.0...

Comment 2

[Iain MacDonnell]

Attachment: Proposed patch

This what you had in mind?

Comment 3

[Blake Ross]

Seems like a simple, low-risk patch.  Plussing to get on Ben's radar.

Comment 4

[timeless]

Comment on attachment 153049 [details] [diff] [review]
Proposed patch

yes, but i don't review code in firefox.

Comment 5

[chris hofmann]

think this have been fixed and the patch would be obosolete.  if not renominate.

thanks

Comment 6

[chris hofmann]

think this has been fixed and the patch would be obosolete.  if not renominate.

thanks

Comment 7

[Iain MacDonnell]

I (In reply to comment #6)
> think this has been fixed and the patch would be obosolete.  if not renominate.

I don't think it's been fixed, but Ben has added a comment:

      // XXXben - do this only for profile until we have a better protection
      // mechanism for global items.

I still think the patch is trivial, and removes an ugliness that shouldn't
be exposed in a preview release...

Comment 8

[Kathleen :Brade]

seek renomination for this bug; I've seen problems when uninstalling

mconnor--please review! :-)

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 153049 [details] [diff] [review]
Proposed patch

r=[e-mail] (minus the bitrot of course)

As bz usually says about these: "error checking is a good thing"

Comment 10

[chris hofmann]

is this ready to check in?

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 153049 [details] [diff] [review]
Proposed patch

>+      if (chromedsFile.exists()) {
>+        chromedsFile.remove(false);
>+      }

No braces around 1-line sub-blocks in my files!

Fix that and r+a=[e-mail]

Comment 12

[chris hofmann]

moconnor or ben, can you land this soon?

Comment 13

[Iain MacDonnell]

I need to make a new version without the superfluous braces *grumble*. I'll
do it this afternoon...

Comment 14

[Iain MacDonnell]

Attachment: New patch without superfluous braces

It took me a while to remember how to reproduce the original problem
(cd ~/,mozilla/firefox/default*; rm -rf extensions chrome/chrome.rdf)

Comment 15

[Iain MacDonnell]

Comment on attachment 157844 [details] [diff] [review]
New patch without superfluous braces

bugzilla doesn't seem to know who [e-mail] is

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

r+a=[e-mail], landed. 

Comment 17

[Asa Dotzler [:asa]]

Comment on attachment 157844 [details] [diff] [review]
New patch without superfluous braces

a=asa for aviary checkin.