245315 - "File > Offline > Download/Sync Now" is disabled when on POP mailbox, even though there are mail/newsboxes to download

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Backend, defect)

Description

[Marcel Waldvogel]

User-Agent:       Mozilla/5.0 (compatible; AhYouWonder)
Build Identifier: 2004052506

I have multiple mailboxes (IMAP and POP) and news accounts. When selecting
"Download/Sync Now", all of them are downloaded, not just the one currently
selected. This is fine. What strikes me is that the menu 

This problem exists since years.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Marcel Waldvogel]

[Oops, accidentally hit return in the wrong field, submitted prematurely; here
is the full entry]

User-Agent:       Mozilla/5.0 (compatible; AhYouWonder)
Build Identifier: 2004052506

I have multiple mailboxes (IMAP and POP) and news accounts. When selecting
"Download/Sync Now", all of them are downloaded, not just the one currently
selected. This is fine. What strikes me is that the menu item is only enabled if
the current account is a downloadable one.

I think this test is wrong. The menu item should be enabled whenever *at least
one* downloadable account exists, not when the current account is downloadable.

This problem is not new.


Reproducible: Always
Steps to Reproduce:
1. In an empty profile, create an IMAP and a POP account
2. Select the POP account
3. Now you cannot download/sync as the menu item is disabled

Comment 2

[David :Bienvenu]

I think it should probably just always be enabled - for pop3, it will get new mail.

Comment 3

[eberry]

Attachment: Diff to enable the Download/Sync command even if a POP/IMAP account is active

This bug has irritated me just enough to fix it.  Here is a trivial diff -u10
patch against the Mozilla 1.7 branch source I made and tested.	This is the
first patch I've submitted, so i don't expect I've got the submission
procedures down 100%.

Marcel, hello again from St Louis!

Comment 4

[g.s]

Same Problem for me in Seamonkey 1.0.4 on Windows:
First I only had on POP3 account and download/sync was impossible. Now I added a NNTP account and download/sync can be used after clicking on the newsserver.
I don't see any reason why download/sync is disabled for POP3

Comment 5

[Serge Gautherie (:sgautherie)]

eberry,
Are you still working on this ?

Comment 6

[eberry]

I posted what seemed to be a working patch several years ago and it got a review/sr, but it never got checked in, and I don't have access to do it myself.  I have not tested the patch recently since I got a little frustrated with the process.  I'll assign this back to the default assignee, since I'm not planning to look into it further, but anyone that wants to should feel free to resurrect the patch/idea and help get it into the product.

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Av1a) current hg patch [Checkin: Comment 9]

David, can you simply confirm the old r+sr, before I check this in.

Comment 8

[David :Bienvenu]

Comment on attachment 384751 [details] [diff] [review]
(Av1a) current hg patch
[Checkin: Comment 9]

looks good, rs=bienvenu.

Comment 9

[Serge Gautherie (:sgautherie)]

Comment on attachment 384751 [details] [diff] [review]
(Av1a) current hg patch
[Checkin: Comment 9]


http://hg.mozilla.org/comm-central/rev/f56caaa0883a

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> but it never got checked in, and I don't have access to do it myself.

Maybe you missed to find someone to commit it :-|
Nowadays, you can use the 'checkin-needed' flag.

> I got a little frustrated with the process.

I know the feeling, yet I hope it will not stop you from contributing again...

> anyone that wants to should feel free to
> resurrect the patch/idea and help get it into the product.

Done ;-)