24533 - `View image' in Navigator should open in the same window

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Joseph Elwell]

on build 2000012008 winNT, if I right click on an image and select View Image it
should not open a new window. In N4.x View Image opens in the current window
which is much friendlier. This might be a new enhancement - or it might be an
overlooked bug.

Comment 1

[Sean Richardson]

Good question. This is either a [4.xP] bug, or a new specification.
File>Open File also uses a new window.

Eli, who would know if there is a spec for this other than [4.xP]?

Comment 2

[Eli Goldberg]

QA Assigning directly to sairuh to investigate, and assigning to German.

(The only menu spec I see on mozilla.org --- http://www.mozilla.org/projects/ui/
netscape/menu_framework/ --- lacks browser-specific contextual menus. Sairuh 
probably knows offhand where the internal spec that isn't yet posted lives.)

Comment 3

[waqar]

*** Bug 22936 has been marked as a duplicate of this bug. ***

Comment 4

[thue]

Just wondering; What does a rendering error in linux (22936) have to do with
showing images in a seperate window under NT (this bug)!?

Comment 5

[Sean Richardson]

Bug 22936 was a DUP of bug 24553, not 24533, just a typo, fixed up now.

Surely this bug is XP. Setting Platform/OS to All/All.

Comment 6

[Matthew T (active 1999-2002)]

German has stated in another bug (I've tried, but I can't find it) that when 
doing File > Open, the new file should open in a new window. I strongly disagree 
with that decision (this is a Web browser, after all), but View Image also 
happening in a different window would be consistent with that.

Comment 7

[Joseph Elwell]

Who is this German guy and how might I go about offing him? :P
Seriously though,I'll be hunting for that bug, because it isn't consistent
within Mozilla. There are at least two ways to open a file and neither do the
same thing.

Comment 8

[Joseph Elwell]

it's bug 14945, and it seems to have been resolved as verified fixed. Anyways, I
notice that this bug is assigned to german. :) Hello there! I like the new File
Open Web Location that allows you to pick whether or not a new window should be
used - Although I think it's not needed. Just opening in the same window all the
time would be nice. Or at least consistent, currently the "File ... Open File"
opens in a new window. Although the default for "File ... Open Web Location ...
Choose File" opens in the same window... I like consistency, and I like browsing
in one window. my preferences are my own - take em as you will.

Comment 9

[shuang (gone)]

Image should be opened and viewed in a new window so current content won't be 
distructed. So current behavior is correct. Mark as WON'TFIX.

Comment 10

[Matthew T (active 1999-2002)]

> Image should be opened and viewed in a new window so current content won't be
> distructed. So current behavior is correct. Mark as WON'TFIX.

Therefore, all links on Web pages should always be opened and viewed in new 
windows too, so that current content won't be destroyed.

So who's going to report the bug about links opening in the same window?

Comment 11

[Matthew T (active 1999-2002)]

See also bug 22342.

Comment 12

[Asa Dotzler [:asa]]

Sorry for the spam.  New QA Contact for Browser General.  Thanks for your help
Joseph (good luck with the new job) and welcome aboard Doron Rosenberg

Comment 13

[Doron Rosenberg (IBM)]

verify

Comment 14

[Matthew T (active 1999-2002)]

Reopening for reconsideration, now that the spec for `File' > `Open' has been 
changed to open the file in the existing window (bug 22342).

I see no reason for treating View Image differently from Open File, Open 
Location, or following a link. They should all open in the same window by 
default.

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

yes. I agree, the hassle of closing the new window after inspecting or saving 
the image to disk is more than simply hitting Alt+<- or clicking back. 

Comment 16

[Adam D. Moss]

I also agree.

Comment 17

[Doron Rosenberg (IBM)]

possible preference setting perhaps?

Comment 18

[Matthew T (active 1999-2002)]

A preference setting would introduce non-obvious modality, and would therefore 
surprise and disconcert users as long as we live in the real world where people 
share Mozilla profiles.

The annoyance of opening in a new window is exacerbated by (but by no means 
solely attributable to) the fact that Mozilla is very slow at opening new windows 
at the moment (compared with 4.x).

Comment 19

[Doron Rosenberg (IBM)]

setting [e-mail] as qa contact, as it should be.

Comment 20

[John Morrison]

I find the current 'open image in a new window' behaviour annoying, and none
of the arguments for doing it this way seem compelling enough to break with 
the Nav4x implementation. 

This is a one-line JS change in nsContextMenu.js.

Adding nsbeta3, with little expectation that this meets the criteria for 
checkins at this point, but maybe this will get some attention in the next
point release after NS6 (and in mozilla, perhaps even earlier).

Comment 21

[german]

I agree with the consistency argument, actually!
It should be the same as opening a file, and since that was decided to be in the
same window so should open image be. this is a good fix for the NS6.5 timeframe
Re-assigning to Ben for consideration...

Comment 22

[Ben Goodger (use ben at mozilla dot org for email)]

very well...

Comment 23

[Blake Ross]

Attachment: patch

Comment 24

[Blake Ross]

review, anyone?

Comment 25

[Blake Ross]

Hmm, nevermind.  That won't work in the sidebar in editor or the addressbook.

Comment 26

[Doron Rosenberg (IBM)]

Attachment: proposed patch

Comment 27

[Doron Rosenberg (IBM)]

attached new proposed patch, any comments?

Comment 28

[Matthew T (active 1999-2002)]

--> XP Apps: GUI

Comment 29

[timeless]

either use [w/ appropriate line wrapping]
if (cond) { statement; } else { statement; }
or
if (cond) statement; else statement;

I'd suggest:
if (windowType.split(":")[0]=="navigator")
  // if navigator, open in current window
  window._content.location.href = this.imageURL;
else //else open a new navigator window
  openNewWindowWith(this.imageURL); 

but using braces would be fine too.

patch content looks good r=timeless. cc alecf for sr=

Comment 30

[Alec Flett]

This is another case where we should probably be going through the URI loader or
something in order to load the URL in an appropriate window.
Another option is to try to look at the target window of the Body - I believe
that the target of sidebar panels is in fact the currently connected browser, no?

Comment 31

[Matthew T (active 1999-2002)]

> Another option is to try to look at the target window of the Body

Wouldn't that give the wrong result for an HTML page which had <base
target="_new"/> in its code? Even for a page which specified that, `View Image' 
should still open in the same window.

Comment 32

[Alec Flett]

true enough. damn.

Comment 33

[Doron Rosenberg (IBM)]

0.9 moving spam

Comment 34

[Gervase Markham [:gerv]]

alecf: Can you sr this patch? Or does it need more work?

Gerv

Comment 35

[Alec Flett]

Nope.. I just discovered recently that the best way is to use openTopWin() from
utilityOverlay.js

Comment 36

[Doron Rosenberg (IBM)]

Attachment: trivial patch

Comment 37

[Doron Rosenberg (IBM)]

I was about to ask alecf if he had found anything about URI loader and js...

trivial patch (really alecf's) attached.

I tested this and it works in sidebar, navigator mailnews and composer.

Comment 38

[Alec Flett]

sr=alecf - easy enough!

Comment 39

[Boris Zbarsky [:bzbarsky]]

r=[e-mail]

Comment 40

[Doron Rosenberg (IBM)]

anyone with cvs access want to check this in? 

Comment 41

[Stephen P. Morse]

Sure, I will.

Comment 42

[Doron Rosenberg (IBM)]

marking fixed, thanks to morse for checking it in.

Comment 43

[sairuh (rarely reading bugmail)]

vrfy fixed:

linux comm 2001.05.02.08
mac comm 2001.05.02.09
winnt moz 2001.05.02.12