245331 - truncatting long filename of attachment

Status: RESOLVED FIXED

(MailNews Core :: Attachments, defect)

Description

[Alexander Koruno]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

This is a part of sample letter with attachment.
Base64-encoded filename is splitted in 2 lines.
In FileSave dialog (and not only) we see only first part of filename, which is
encoded in first line...

Content-Type: application/msword;
name==?koi8-r?B?9yDP087P18Ug1MXIzs/Mz8fJySDMxdbJ1CDIz9LP288gydrXxdPUztnKINrB?=
  =?koi8-r?B?y8/OINDP18XSyM7P09TOz8fPIM7B1NHWxc7J0SDWycTLz9PUyS5kb2M=?=
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename==?koi8-r?B?9yDP087P18Ug1MXIzs/Mz8fJySDMxdbJ1CDIz9LP288gydrXxdPUztnKINrB?=
  =?koi8-r?B?y8/OINDP18XSyM7P09TOz8fPIM7B1NHWxc7J0SDWycTLz9PUyS5kb2M=?=


Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Bogdan Stroe]

See also bug 186974, bug 80220, and bug 112162.
Could this one be related?

Comment 2

[Alexander Koruno]

(In reply to comment #1)
> See also bug 186974, bug 80220, and bug 112162.
> Could this one be related?

May be the first bug (186974) have the same source...

Comment 3

[Fabian Rodriguez:MagicFab]

Can you attach the file to this bug report ? And what is the filename ? 

Comment 4

[David :Bienvenu]

Attachment: proposed fix

make the minimum size 15, but don't set a max - this will show large attachment
names in full, which I think is worth the potential unrulyness of the
attachment area when you have attachments with different length names.

Comment 5

[Scott MacGregor]

actually this looks better than I thought it would for attachments with
different sizes. It looks like we end up making all of them the same width (just
the widest width of the longest attachment name).

Only problem I see so far is when your message has a horizontal scrollbar as
well, clicking on these attachments is causing the message pane area to jiggle
back and forth. I'm not sure why yet. 

Comment 6

[Scott MacGregor]

actually the jiggling effect is only present when you have a horizontal
scrollbar inside the message pane box. 

vertical scrollbars do not cause any jiggling with this patch

Comment 7

[Scott MacGregor]

I can now reproduce the jiggling effect even without David's patch just by
making the message pane narrower. It just happens that you'll notice it more
since we aren't constraining the width of the attachment name anymore. 

Comment 8

[Scott MacGregor]

I checked this into the branch and the trunk for both the default theme and
pinstripe for OS X. 

Comment 9

[Ben Bucksch (:BenB)]

mscott, my (unfinished) patch for bug 9942 may influence or fix the jiggling,
havn't tried it.