245653 - components/build/nsModule tries to build with dogbert migration under BeOS, causing build to fail. AVIARY_1_0_20040515_BRANCH

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[tqh]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.8a) Gecko/20040515 Firefox/0.8.0+
Build Identifier: 

nsModule.cpp should not include dogbert profile migration for BEOS.

Reproducible: Always
Steps to Reproduce:

Comment 1

[tqh]

Attachment: patch to remove Dogbert from BeOS builds

Comment 2

[tqh]

Updated summary. Forgot to specify the AVIARY_1_0_20040515_BRANCH. Setting target. 

Comment 3

[tqh]

Comment on attachment 150078 [details] [diff] [review]
patch to remove Dogbert from BeOS builds

requesting review

Comment 4

[Sergei Dolgov]

Comment on attachment 150078 [details] [diff] [review]
patch to remove Dogbert from BeOS builds

r=[e-mail]

Comment 5

[Brian Ryner (not reading)]

- Does this actually break the beos build?
- If so, why?
- If we want to not build this, it should be ifdef'd in
browser/components/migration/src/Makefile.in as well.

Comment 6

[tqh]

(In reply to comment #5)
> - Does this actually break the beos build?
> - If so, why?
> - If we want to not build this, it should be ifdef'd in
> browser/components/migration/src/Makefile.in as well.
> 

Have you taken a look at that file?
From Makefile.in:
ifneq ($(OS_ARCH),BeOS)
CPPSRCS += nsDogbertProfileMigrator.cpp
endif

That's why the build is broken in the first place, the Makefile.in is already
correct.

Comment 7

[tqh]

Comment on attachment 150078 [details] [diff] [review]
patch to remove Dogbert from BeOS builds

requesting sr
(and checkin if positive)

Comment 8

[tqh]

updating target milestone.

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 150078 [details] [diff] [review]
patch to remove Dogbert from BeOS builds

r/a=me for landing on aviary/trunk

Comment 10

[tqh]

I'll close this one when I can get a full build and verify. Currently stuck on
bug 251327

Comment 11

[tqh]

mconnor, could you please commit this to AVIARY.

(I should get myself a CVS account).

Comment 12

[Mike Connor [:mconnor]]

hrm, at this point it needs approval-aviary from a very small group, set the
flag, once its approved I can land it

Comment 13

[tqh]

Comment on attachment 150078 [details] [diff] [review]
patch to remove Dogbert from BeOS builds

need approval

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 150078 [details] [diff] [review]
patch to remove Dogbert from BeOS builds

a=asa for checkin to aviary.

Comment 15

[tqh]

mconnor, can you please check this in so it can be closed?

(Firefox for BeOS will build from CVS with this checkin which makes me very happy).

Comment 16

[Brian Ryner (not reading)]

checked into trunk and aviary branch