Closed
Bug 245772
Opened 22 years ago
Closed 22 years ago
Pointless null checks in SOAP code
Categories
(Core Graveyard :: Web Services, defect)
Core Graveyard
Web Services
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: keeda, Assigned: keeda)
Details
Attachments
(1 file)
|
38.12 KB,
patch
|
peterv
:
review+
peterv
:
superreview+
|
Details | Diff | Splinter Review |
SOAP code does NS_ENSURE_ARG_POINTER(&aFoo) in a lot of places where aFoo is a
reference to a string. I don't see much point in doing this. Its just bloat.
|
Assignee | |
Comment 1•22 years ago
|
||
This was done using a little script that checks for anything that looks like
NS_ENSURE_ARG_POINTER(&..... I then checked the results manually.
|
|
Assignee | |
Comment 2•22 years ago
|
||
Comment on attachment 150192 [details] [diff] [review]
Fix
peterv, it would be great if you could rs/r this ... or something like that.
This is trivial and was scripted anyway.
Attachment #150192 -
Flags: review?(peterv)
|
||
Comment 3•22 years ago
|
||
Comment on attachment 150192 [details] [diff] [review]
Fix
Thanks.
Attachment #150192 -
Flags: superreview+
Attachment #150192 -
Flags: review?(peterv)
Attachment #150192 -
Flags: review+
|
|
Assignee | |
Comment 4•22 years ago
|
||
Thanks for the quick review.
Checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•