245885 - Extension Manager totally useless in latest custom Aviary build (possibly related to JS syntax error)

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Bradley Chapman (not reading bugmail, still gone but not forever)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040605 Firefox/0.8.0+ (daihard: XFT+GTK2; opt. for P4/SSE-2)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040607 Firefox/0.8.0+ (daihard: XFT+GTK2; opt. for P4/SSE-2)

When attempting to install the Adblock extension (or any other 0.9-compatible
extension) into a custom build from the latest Aviary source code, the Extension
Manager does not do anything at all after showing the initial load screen.
Checking the JavaScript console shows this error:

Error: syntax error
Source File: chrome://mozapps/content/extensions/extensions.js
Line: 603, Column: 50
Source Code:
      gExtensionsViewController.onCommandUpdate();</pre>

Reproducible: Always
Steps to Reproduce:
1. Install the custom build shown (Mozilla/5.0 (X11; U; Linux i686; en-US;
rv:1.8a2) Gecko/20040607 Firefox/0.8.0+ (daihard: XFT+GTK2; opt. for P4/SSE-2))
2. Enable software installation in Options->Advanced
3. Attempt to install the Adblock extension

Actual Results:  
The Extension Manager popped up, empty, and the JavaScript Console showed the
error detailed above.

Expected Results:  
The Extension Manager should have shown some sort of activity, and the JS
Console should have shown no error.

This is the first Aviary build I have tried, so I don't know how long it has
been broken.

Comment 1

[Bradley Chapman (not reading bugmail, still gone but not forever)]

Whoops!

The UA strings should of course say rv:1.7 instead of rv:1.8a2. I miscopied them.

Comment 2

[Steffen Wilberg]

The </pre> tag was checked in by mistake and has already been removed again by
Ben's checkin from 2004-06-08 03:09.
->fixed.