246112 - "Document: Done" is meaningless and should be removed

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[timeless]

Comment 1

[timeless]

1. Build Camino or download Camino
2. Run Camino
3. Cmd-B
4. Stare at "Document: Done" at the bottom of the window

Expected results:
Don't show Document: Done at all, it doesn't mean anything useful.

Actual results:
"Document: Done" in the bottom left corner of the window.

Comment 2

[Mike Pinkerton (not reading bugmail)]

this is a mozilla artifact. i guess we could remove it.

Comment 3

[timeless]

i actually have a patch for this, but it's my first real .mm patch, so feel 
free to write your own.

Comment 4

[Jasper]

If you have a patch please just post it.

Comment 5

[timeless]

Attachment: Hide statusbar while showing bookmarks; add show/hide statusbar item Safari parity

Comment 6

[timeless]

Attachment: nib change

Comment 7

[timeless]

Comment on attachment 150538 [details] [diff] [review]
Hide statusbar while showing bookmarks; add show/hide statusbar item Safari parity

Sorry about the borked RCS file lines, that's from a script I used, it's fixed
elsewhere I'll try to get it consistently fixed so that I stop sending bogus
lines.

perl -pi -e 's{/cvsroot//}{/}g' patchfile

should fix it

--
This is my first real mm change, and my first use of IB...

--
The dimensions for the bookmarks manager don't seem to be quit right, i'd want
it to be slightly taller, i'm not sure why they're wrong or how to fix that.

Comment 8

[Jasper]

The part of your patch that allows hiding and showing of the status bar belongs
to Bug 159233, so our paperwork is ok.

So what you are doing is just hiding the status bar when in BM mode, sounds like
a plan to me. Guys what do you think.

(sorry I'm not a coder so I can't revew the actual patch)

Comment 9

[Josh Aas]

Comment on attachment 150538 [details] [diff] [review]
Hide statusbar while showing bookmarks; add show/hide statusbar item Safari parity

Whether or not this patch works, it'll need to be updated for review as it is
out of date (the nib file for sure).

Comment 10

[L. H.]

This looks like a one line change to Localizable.strings
-"DocumentDone" = "Document: Done";
+"DocumentDone" = "";

Comment 11

[timeless]

[e-mail]: the issue isn't that "document: done" is globally
meaningless, the issue is that it's meaningless when the window you're starting
at is *bookmarks* and not something resembling a document.

Comment 12

[L. H.]

It is globally meaningless because blank tells you that nothing is going on just
as much and is easier to tell apart from having loading information. Safari uses
blank.

But I noticed the right fix is really to change
mLoadingStatusString = [NSLocalizedString(@"DocumentDone", @"") retain];
in BrowserWrapper.mm and take away the Localizeable.strings line.

Comment 13

[Josh Aas]

I want this on 0.9 for now. Its quite bad for our UI.

Comment 14

[Josh Aas]

Attachment: patch v1.0

The patch posted by timeless belongs in another bug, as noted earlier in this
bug by jasper. Here is the real fix.

Comment 15

[Josh Aas]

Attachment: remove document done string from localizable strings file

Comment 16

[Josh Aas]

The patch is actually bad - even the empty string should be retained.

Comment 17

[Josh Aas]

Landed on trunk with empty string retained.