246267 - [Seamonkey] Trailing period causes extension protection code to fail (e.g. "nc.exe.")

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[timeless]

Confirmed using mozilla 1.7b branch.

From Firefox bug 246184:
When trying to download a file with an on-server extension of ".exe.", the
download manager does not recognize it as being the same as ".exe". On Windows
you can't have a filename end with a ".", it just gets stripped. That means that
".exe." yields ".exe", which is an application. The DM does not recognize it as
such, and enables the "Open with" option.


Reproducible: Always
Steps to Reproduce:

1. Download a file ending in ".exe." (http://jan.moesen.nu/tempz0r/nc.exe.)
A. Open With
 2a. Choose "Open With" without specifying anything

B. Download Manager
 2b. Choose "Save to disk"
 3b. Pick a file location and click Save
 4b. Click Launch File

Actual Results:  
It ran the executable.

Expected Results:  
Give the usual executable warning.

Comment 1

[timeless]

ignore 2a, we'll cover that in bug 246280.

Comment 2

[Ben Bucksch (:BenB)]

Note to self: nsLocalFileWin.cpp::IsExecutable()

Comment 3

[[e-mail]]

FYI GetFullPathName removes all trailing periods from the file name and also one
period from each intervening directory name.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

patch in bug 246280 fixes this one as well

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

should be fixed with bug 246280; please verify