246344 - XHTML page wrongly saved: <BR />, <IMG .../> tags

Status: RESOLVED DUPLICATE of bug 205264

(SeaMonkey :: General, defect)

Description

[Leonard Mada]

User-Agent:       Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 4.0)
Build Identifier: Mozilla 1.6, 1.7 RC 1, 1.7 RC2

<BR />, <IMG .../> tags and another TAG (I think it was <META .../>) are 
wrongly converted to <BR>, <IMG ...> and <META ...> without closing, when 
saving an XHTML-Transitional page locally. To be XHTML-Transitional compliant, 
those tags MUST be however properly closed.

Reproducible: Always
Steps to Reproduce:
1.open any XHTML-Transitional web page that contains such tags
2.save locally
3.open in an editor and search for those tags

Actual Results:  
<BR /> => <BR>
<IMG ... /> => <IMG ... > without closing
(I think <META ... /> => <META ...>, too)

Expected Results:  
To be XHTML-Transitional compliant, those tags (<BR />, <IMG ... />) MUST be 
however properly closed.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

> 1.open any XHTML-Transitional web page that contains such tags

what was the content-type of the file? if it was text/html this bug is invalid,
since xhtml files should be sent as application/xhtml+xml or some other xml mime
type.

Comment 2

[Leonard Mada]

(In reply to comment #1)
> > 1.open any XHTML-Transitional web page that contains such tags
> 
> what was the content-type of the file? if it was text/html this bug is invalid,
> since xhtml files should be sent as application/xhtml+xml or some other xml mime
> type.

Thanks. I never thought of this. I'll test it.

BUT, shouldn't it save all those tags closed (or have at least an option to do
this: IF the original page contained those tags closed, so should they be saved).

Comment 3

[Leonard Mada]

Unfortunately, even application/xhtml+xml did NOT correct the problem.

When looking carefully at the code, I found an additional bug:

 * url/links/anchors are not url-encoded, e.g. <a name="my%20name"> becomes <a 
name="my name">, even if the original page contained the encoded version (when 
I select view page source, the correct page is displayed, BUT NOT when saved).

But Mozilla still saved the header xhtml1.0-transitional and 
application/xhtml+xml, so this is definetively wrong.

It's not a critical error, but still would be nice to correct.

Kind regards

Leonard Mada.

Comment 4

[Leonard Mada]

Well, I found additional information here: see bug 193060. That one seems to be 
corrected, as ViewSource did display the original page (with <br /> and 
everything else), only when saving, these things are removed.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #2)
> BUT, shouldn't it save all those tags closed (or have at least an option to do
> this: IF the original page contained those tags closed, so should they be saved).

why? it didn't have the tags closed. it just had a random slash in the tag.

(In reply to comment #3)
> Unfortunately, even application/xhtml+xml did NOT correct the problem.

Hmm, so even then the tags were not closed?

Does View|Page Info show the correct mime type, i.e. application/xhtml+xml?

> When looking carefully at the code, I found an additional bug:

please file additional bugs separately...

> But Mozilla still saved the header xhtml1.0-transitional and 
> application/xhtml+xml, so this is definetively wrong.

mozilla doesn't "save" mimetypes... maybe the doctype should've been changed, I
suspect we may have a bug about this already...

Comment 6

[Jesse Ruderman]

*** This bug has been marked as a duplicate of 205264 ***