246429 - Extension about dialog empty if the optional fields description and/or creator are missing

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[PikeUK]

According to the Firefox extension packaging spec the description and creator
fields are optional, however if you leave them out of the install manifest the
about box for an extension appears empty:

http://www.bengoodger.com/software/mb/extensions/packaging/extensions.html

The following test extension from Bug 246417 demonstrates this, I'll make a
specific testcase if anyone wants me to:

http://www.pikey.me.uk/mozilla/test/updatetest.xpi

A couple of if()s in mozilla/toolkit/mozapps/extensions/content/about.js should
fix this, patch coming up.

Comment 1

[PikeUK]

Attachment: Add some ifs to guard against QI-ing a null value

Patch

Comment 2

[PikeUK]

Comment on attachment 150580 [details] [diff] [review]
Add some ifs to guard against QI-ing a null value

Requesting review for ultra-trivial patch

Comment 3

[PikeUK]

In case it's not obvious, by "Extension about dialog" I mean:

Tools->Extensions->Right-click an extension->About <Extension Name>

Comment 4

[James Ross]

Comment on attachment 150580 [details] [diff] [review]
Add some ifs to guard against QI-ing a null value

Checked into the Aviary branch. I did not check into the trunk because I'm not
sure if sr is needed or not.

Comment 5

[Steffen Wilberg]

SR is not needed: http://www.mozilla.org/projects/firefox/review.html
Mike's not a peer, but Ben allowed him to review minor patches.

Comment 6

[James Ross]

Ok, checked into trunk as well. :)  (it seems to be not showing up on Tinderbox
or LXR yet, but bonsai knows about it)

Marking FIXED as the patch addresses all the issues raised in this bug.

Comment 7

[Stephen Walker]

ben reverted this with one of his trunk checkins.

Comment 8

[Steffen Wilberg]

But he fixed it again with his second "for real this time" trunk landing, rev.
1.7 of about.js:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=about.js&branch=&root=/cvsroot&subdir=mozilla/toolkit/mozapps/extensions/content&command=DIFF_FRAMESET&rev1=1.6&rev2=1.7

->fixed.