246614 - GIF Image with a large number of frames (52 frames) causes the browser to crash [@ nsImageMac::CopyBitsWithMask ]

Status: RESOLVED DUPLICATE of bug 246245

(Core Graveyard :: Image: Painting, defect)

Description

[Paul Bergsagel]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040608
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040608

Follow the included link and load the image. Wait about 10 t0 30 seconds and
this animated GIF will crash the browser.

Reproducible: Always
Steps to Reproduce:
1.Load an animated GIF with a large number of frames (URL linked GIF has 52 frames)
2.wait
3.browser crash.

Actual Results:  
Crash.

Expected Results:  
No crash.

I am runing Mac OS X 10.3.4 B/W G3-350 512mb.

I am including a crash log.

Comment 1

[Paul Bergsagel]

Attachment: Mac crashreporter log when GIF caused the browser to crash.

Comment 2

[Olivier Cahagne]

possible regression from bug 239701 and bug 195022 ?

Comment 3

[Paul Bergsagel]

Additional information: When the Activity Monitor is open as the GIF image is
loaded I noticed that the memory Mozilla uses rises very rapidly until all
available free memory is used up. When all free memory is used up the lack of
more free memory causes the browser the crash. The memory used by Mozilla does
not trigger the OS to begin using virtual memory as one would expect. I have
512MB of memory and I believe if a user had a very large amount of memory
installed (>512mb, say 1GIGmb that the image may display properly. The issue may
possibly involve a massive memory leak by Mozilla.

BTW the image can be correctly displayed by Safari.

Can anyone test to verify if this is a Mac only bug? I do not have access to any
other platform than Mac. If it occurs on either Windows or Linux than we can
rule out a regression due to the fix for bug 239701 and bug 195022.

Comment 4

[yamal]

No problems with xp.

Comment 5

[timeless]

fwiw it worked for me w/ my camino build (cvs circa jun 8).

Comment 6

[jhp (no longer active)]

Paul: Could you please try the Mozilla 1.7rc2 version available at
http://ftp28f.newaol.com/pub/mozilla.org/mozilla/releases/mozilla1.7rc2/mozilla-mac-1.7rc2.dmg.gz.

Comment 7

[jhp (no longer active)]

I can confirm comment #3.  The nsImageMac patch in bug 246245 takes care of most
of the leak, although Activity Monitor still shows some more leaking.

Comment 8

[jhp (no longer active)]

Duping to 246245.

*** This bug has been marked as a duplicate of 246245 ***

Comment 9

[Paul Bergsagel]

Since this bug has been resolved as a duplicate, I will still report on my test
with Moz RC2 for waht it is worth. The animated GIF displayed without crashing,
although it failed to properly display the GIF image (individual fames) properly
the animation worked as expected. I am attaching a screenshot. The fix for the
broken GIFs appears to have created massive memory leaks which crash the browser
when displaying animated GIF with a large number of frames.

Comment 10

[Paul Bergsagel]

Attachment: Screenshot of animated GIF as displayed in RC2