247143 - Buggy 'firefox' *nix script & a patch to patch it up a little... ;)

Status: RESOLVED DUPLICATE of bug 177996

(Firefox :: Shell Integration, defect)

Description

[Mike Sowka]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040615 Firefox/0.9
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040615 Firefox/0.9

#1 --remote doesn't work properly, I did not look into this any further but I ge
the feeling it's not handled at all

#2 Even though the "profile in use dialog" problem has been fixed, it still
occured when a url was supplied to the firefox script. Attached is a quick patch
that I've written, with my VERY LIMITED BASH KNOWLEDGE...

Reproducible: Always
Steps to Reproduce:
1. Open a window with 'firefox'
2. Try to open another window with 'firefox www.slashdot.org'
3.

Actual Results:  
pops up the "user profile in use" dialog

Expected Results:  
a new window with the supplied URL

Comment 1

[Mike Sowka]

Attachment: A patch to patch up the firefox script...

Comment 2

[Roland Mainz]

-- snip --
 ## Start addon scripts
 moz_pis_startstop_scripts "start"
 
+# open the supplied url in a new window
+if [ $ALREADY_RUNNING -eq 1 ]
+then
+  exec $MOZ_CLIENT_PROGRAM -a firefox "openurl($1,new-window)" 2>/dev/null
>/dev/null
+fi
-- snip --

... that won't fly - "exec" will replace the current shell instance with
$MOZ_CLIENT_PROGRAM and then |moz_pis_startstop_scripts "stop"| will never be
called. Please move that statement before the "start" item...

Comment 3

[Mike Sowka]

Hrmmm... Well, what ever that means, all I know is it works for me ;) .

Comment 4

[Ali Ebrahim]

I'm pretty sure this is a dupe. I could be wrong, so feel free to correct and
reopen.

*** This bug has been marked as a duplicate of 177996 ***