247406 - secport.h has PORT_Strdup in C++ unsafe section

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Julien Pierre]

PORT_Strdup was changed from a macro to a function . But it isn't in the extern
"C" section of the file . This caused some of our admin applications not to link.
I will attach a fix for it.

While reviewing this file, I noticed something about XP_STRINGS_FUNCS and
different definitions, including for PORT_Strdup . Is that section every used,
and if so, by who ? It seems dangerous . Can it be removed ?

Comment 1

[Julien Pierre]

Attachment: move PORT_Strdup to extern "C" section

Comment 2

[Wan-Teh Chang]

Comment on attachment 151062 [details] [diff] [review]
move PORT_Strdup to extern "C" section

Julien, please also remove the line:

#define PORT_Strdup	XP_STRDUP

or the whole #ifdef XP_STRING_FUNCS block.
This is to prevent the (dead) code from
becoming inconsistent.

Nit: it looks nicer to move PORT_Strdup
under PORT_ZFree.

Comment 3

[Wan-Teh Chang]

Julien, if I remember correctly, the XP_STRING_FUNCS
section is for old Netscape browser code predating
NSPR.  That section is dead code now.  I suggest that
we remove it.  Bob, Nelson, what do you think?

Comment 4

[Wan-Teh Chang]

Attachment: move PORT_Strdup to extern "C" section; remove XP_STRING_FUNCS section

Comment 5

[Julien Pierre]

Comment on attachment 151068 [details] [diff] [review]
move PORT_Strdup to extern "C" section; remove XP_STRING_FUNCS section

Looks good.

Comment 6

[Robert Relyea]

comment #3, 
<begin sarcasm>
I don't know. I think that code is on a 25 year depriciation schedule.:)
<end sarcasm>

I'm pretty sure we aren't going to resurrect XP_ code so I don't have any 
objections to removing the section.

bob

Comment 7

[glen beasley]

Comment on attachment 151068 [details] [diff] [review]
move PORT_Strdup to extern "C" section; remove XP_STRING_FUNCS section

patch looks good.

Comment 8

[Julien Pierre]

Checked in to NSS_3_9_BRANCH :

Checking in secport.h;
/cvsroot/mozilla/security/nss/lib/util/secport.h,v  <--  secport.h
new revision: 1.8.2.1; previous revision: 1.8
done

And tip :

Checking in secport.h;
/cvsroot/mozilla/security/nss/lib/util/secport.h,v  <--  secport.h
new revision: 1.11; previous revision: 1.10
done

Comment 9

[Nelson Bolyard (seldom reads bugmail)]

The entire PORT_ set of macros and functions was originally created back
when the Netscape browser source was beginning to migrate to use the modern
NSPR (which was then known as NSPR2).  The PORT macros expanded to either
NSPR 1 symbols (XP_*) or other symbols depending on some #defines.
The XP_ code is now ancient history.  I agree that stuff can all be removed.