247537 - IHtmlElement::insertAdjacentHtml & put_id implementations

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: ActiveX Wrapper, enhancement)

Description

[Alexandre Trémon]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040616
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040616

IHtmlElement::insertAdjacentHtml & put_id implementations are not yet provided
in CIEHtmlElement

Reproducible: Always
Steps to Reproduce:

Comment 1

[Alexandre Trémon]

Attachment: IHtmlElement::insertAdjacentHtml & put_id implementations

IHtmlElement::insertAdjacentHtml & put_id implementations in CIEHtmlElement

Comment 2

[Adam Lock]

Comment on attachment 151128 [details] [diff] [review]
IHtmlElement::insertAdjacentHtml & put_id implementations

insertAdjacentHTML needs a USES_CONVERSION macro and OLE2CW instead of OLE2W.

Otherwise r=adamlock

Comment 3

[Alexandre Trémon]

Attachment: Uses_Conversion & OLE2CW

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 155912 [details] [diff] [review]
Uses_Conversion & OLE2CW

- In CIEHtmlElement::put_id():

+    nsAutoString strID(OLE2CW(v));

Any reason not to use nsDependentString here to avoid a string copy and
possibly a malloc/free?

- In CIEHtmlElement::get_id():

+	 return SUCCEEDED(rv)?S_OK: E_FAIL;

Maybe be more consistent with spacing around the operators there (and in all
other occurances), how about:

+	 return SUCCEEDED(rv) ? S_OK : E_FAIL;

sr=jst

Comment 5

[Johnny Stenback (:jst)]

Forgot to mention that the nsAutoString in CIEHtmlElement::insertAdjacentHTML()
could be an nsDependentString too, unless I missed something...

Comment 6

[Alexandre Trémon]

(In reply to comment #5)
> Forgot to mention that the nsAutoString in CIEHtmlElement::insertAdjacentHTML()
> could be an nsDependentString too, unless I missed something...

Thanks for reviewing, Johnny!
nsAutoString makes a copy of the buffer, unlike nsDependentString, is that it?
Even with the string guide, I don't know much of the subtelties of Mozilla's
strings yet ... :-)

Comment 7

[Alexandre Trémon]

Attachment: following Johnny's comments

Comment 8

[Alexandre Trémon]

Adam,

Can you check in this patch for me?

Thanks!

Comment 9

[Adam Lock]

Fix checked in with one minor modification to add a missing #include
"nsIDOMHtmlElement.h" that may have been included by something else originally
but isn't anymore.

Comment 10

[Colin Blake]

How does one use insertAdjacentHTML? If I go some place such as:

  http://webfx.eae.net/bombProject/bomberman.html

I get this on the js console:

  Error: document.body.insertAdjacentHTML is not a function
  Source File: http://webfx.eae.net/bombProject/bomberman.html
  Line: 39

Comment 11

[Alexandre Trémon]

> How does one use insertAdjacentHTML? If I go some place such as:
> 
>   http://webfx.eae.net/bombProject/bomberman.html
> 

I suppose you use your browser on that page. InserAdjacentHtml is not implemented in seamonkey/firefox.
This here is about the ActiveX control, a bridge that can be used by apps where you want to replace the ShellDocView control (IE) by Gecko.