2478 - {css1} CSS doesn't work on FORM element

Status: VERIFIED DUPLICATE of bug 2082

(Core :: Layout, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Box properties (or at least margin-left) don't work on the form element.

I'm using build 99-01-15.

(I will submit a separate bug for the table problems in the above page.  It
will probably have a number one higher than this bug.)

Comment 1

[troy]

With top-of-trunk sources we're hitting an assert in the table frame code

NTDLL! 77f76148()
nsDebug::PostCondition(const char * 0x0068f5e0, const char * 0x0068f5cc, const
char * 0x0068f598, int 4583) line 120 + 13 bytes
nsTableFrame::GetTableFrame(nsIFrame * 0x00fb5160, nsTableFrame * & 0x00000000)
line 4583 + 34 bytes
nsTableCellFrame::MapBorderMarginPadding(nsIPresContext * 0x00f27f60) line 710
nsTableCellFrame::DidSetStyleContext(nsTableCellFrame * const 0x00fb5160,
nsIPresContext * 0x00f27f60) line 842
nsFrame::SetStyleContext(nsFrame * const 0x00fb5160, nsIPresContext *
0x00f27f60, nsIStyleContext * 0x00fb5340) line 379
nsFrame::Init(nsFrame * const 0x00fb5160, nsIPresContext & {...}, nsIContent *
0x00faac7c, nsIFrame * 0x00fb5980, nsIStyleContext * 0x00fb5340) line 219
HTMLStyleSheetImpl::ConstructTableCellFrame(nsIPresContext * 0x00f27f60,
nsIContent * 0x00faac7c, nsIFrame * 0x00fb5980, nsIStyleContext * 0x00fb5340,
nsAbsoluteItems & {...}, nsIFrame * & 0x00fb5160) line 1380
HTMLStyleSheetImpl::ConstructFrameByDisplayType(nsIPresContext * 0x00f27f60,
const nsStyleDisplay * 0x00fb5510, nsIContent * 0x00faac7c, nsIFrame *
0x00fb5980, nsIStyleContext * 0x00fb5340, nsAbsoluteItems & {...}, nsIFrame * &
0x00fb5160) line 2045 + 32 bytes
HTMLStyleSheetImpl::ConstructFrame(nsIPresContext * 0x00f27f60, nsIContent *
0x00faac7c, nsIFrame * 0x00fb5980, nsAbsoluteItems & {...}, nsIFrame * &
0x00fb5160) line 2224 + 36 bytes
HTMLStyleSheetImpl::ProcessChildren(nsIPresContext * 0x00f27f60, nsIContent *
0x00fa922c, nsIFrame * 0x00fb5980, nsAbsoluteItems & {...}, nsIFrame * &
0x00fb5560) line 1044
HTMLStyleSheetImpl::ConstructFrameByDisplayType(nsIPresContext * 0x00f27f60,
const nsStyleDisplay * 0x00fb5c90, nsIContent * 0x00fa922c, nsIFrame *
0x00fa9770, nsIStyleContext * 0x00fb5ac0, nsAbsoluteItems & {...}, nsIFrame * &
0x00fb5980) line 2074 + 30 bytes
HTMLStyleSheetImpl::ConstructFrame(nsIPresContext * 0x00f27f60, nsIContent *
0x00fa922c, nsIFrame * 0x00fa9770, nsAbsoluteItems & {...}, nsIFrame * &
0x00fb5980) line 2224 + 36 bytes
HTMLStyleSheetImpl::ContentAppended(HTMLStyleSheetImpl * const 0x00f5f8c4,
nsIPresContext * 0x00f27f60, nsIContent * 0x00fa010c, int 1) line 2391
StyleSetImpl::ContentAppended(StyleSetImpl * const 0x00f9b350, nsIPresContext *
0x00f27f60, nsIContent * 0x00fa010c, int 1) line 742
PresShell::ContentAppended(PresShell * const 0x00f9b078, nsIDocument *
0x00f597e0, nsIContent * 0x00fa010c, int 1) line 1019 + 33 bytes
nsDocument::ContentAppended(nsDocument * const 0x00f597e0, nsIContent *
0x00fa010c, int 1) line 921
nsHTMLDocument::ContentAppended(nsHTMLDocument * const 0x00f597e0, nsIContent *
0x00fa010c, int 1) line 537
HTMLContentSink::WillInterrupt(HTMLContentSink * const 0x00f5f590) line 1469
CNavDTD::WillInterruptParse(CNavDTD * const 0x00f9cd20) line 2529 + 18 bytes
nsParser::ResumeParse(nsIDTD * 0x00000000) line 682
nsParser::OnDataAvailable(nsParser * const 0x00f5f6a4, nsIURL * 0x00f23350,
nsIInputStream * 0x00f20790, unsigned int 1445) line 868 + 17 bytes
nsDocumentBindInfo::OnDataAvailable(nsDocumentBindInfo * const 0x00f21030,
nsIURL * 0x00f23350, nsIInputStream * 0x00f20790, unsigned int 1445) line 1705 +
24 bytes
OnDataAvailableProxyEvent::HandleEvent(OnDataAvailableProxyEvent * const
0x00f540a0) line 625
StreamListenerProxyEvent::HandlePLEvent(PLEvent * 0x00f540a4) line 464 + 12
bytes
PL_HandleEvent(PLEvent * 0x00f540a4) line 395 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x00ecffa0) line 357 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x00010740, unsigned int 49303, unsigned int 0,
long 15531936) line 675 + 9 bytes
USER32! 77e71250()
00ecffa0()

Comment 2

[leger]

Setting all current Open/Normal to M4.

Comment 3

[Paul MacQuiddy]

per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser

Comment 4

[karnaze (gone)]

Moving to M5.

Comment 5

[karnaze (gone)]

Moving to M6.

Comment 6

[karnaze (gone)]

Moving to M8.

Comment 7

[karnaze (gone)]

Reassigning to Pierre.

Comment 8

[Hixie (not reading bugmail)]

The <form> element is very ill with respect to CSS.

To start with, it is neither a block nor an inline element.

Take the following document:

   <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN">
   <style type="text/css">
      form { display: block; }
   </style>
   <title>Mozilla Tests: form css </title>
   <div>
      before
      <form>during</form>
      after
   </div>

Mozilla lays it out as

   before
   during after

...which is *very* wrong.

Furthermore, padding, border, background, margin, color, fonts -- probably
all CSS properties, in fact -- have no effect.

Finally, the ua.css stylesheet is missing margins on <form>. It should read:

   form {
     display: block;
     margin: 1em 0;
   }

This is causing lots of bugs to be assigned to the tables and forms componenets.

Peterl: I am ccing you in case you wish to quickly fix the margins in ua.css.
FYI, legacy browsers act as if they had 1em top and bottom margins on forms,
so I suggest we do the same.

Comment 9

[Hixie (not reading bugmail)]

*** Bug 2644 has been marked as a duplicate of this bug. ***

Comment 10

[Hixie (not reading bugmail)]

*** This bug has been marked as a duplicate of 2082 ***

Comment 11

[Jay Patel [:jay]]

Verified Dup

Comment 12

[Hixie (not reading bugmail)]

Migrating from {css1} to css1 keyword. The {css1}, {css2}, {css3} and {css-moz}
radars should now be considered deprecated in favour of keywords.
I am *really* sorry about the spam...