Closed Bug 247816 Opened 17 years ago Closed 6 years ago

Adding float style causes some pre-existing style attributes to be dropped

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: danm.moz, Unassigned)

References

Details

(Recent trunk build:) Margin style attributes seem to be selectively dropped
when an image is given a float style.

1) Write a new HTML message.
2) Drop an image into its body.
3) Give it margins (Image Properties -> Advanced Edit -> Inline Style)
   Make it "margin: 20".
3a) Ummm I wanted to add another attribute. Click OK to accept the margin
    and dismiss the dialog.
3b) Return to Inline Style. Note how the one property has become eight. Yay.
4) Add the style "float: left". Click OK.
5) Return to Inline Style.

Six of the eight margin properties have been dropped. Specifically the left and
right margins are gone.
Depends on: 241234
This is a basic editor problem, seen in NVu and Mozilla Composer.
Margin is not the only attribute affected; padding is also, altho border is not.

Incidentally: to add another attribute, just put the focus back on the attribute 
name and type a new one, you don't have to dismiss the dialog.  Not intuitive, 
but it works.
Assignee: mscott → mozeditor
Component: Mail Window Front End → Editor
OS: Windows XP → All
Product: Thunderbird → Core
QA Contact: bugzilla
Hardware: PC → All
Summary: float style causes some margin style attributes to be dropped → Adding float style causes some pre-existing style attributes to be dropped
Version: unspecified → Trunk
*** Bug 351620 has been marked as a duplicate of this bug. ***
Summary should state that adding/editing any style attribute removes margin-left,margin-right, or padding-left,padding-right attributes.
Screenshot of the advanced editor window: http://img241.imageshack.us/img241/3084/advancededituz8.gif
margin-left-value, margin-right-value,padding-left-value,padding-right-value
were added as "internal use" items in this checkin for bug 74880
https://bugzilla.mozilla.org/attachment.cgi?id=140573

Regression range testing:(from archives)
Thunderbird 0.5a (20040113) works fine
Thunderbird 0.5+ (20040222) shows the bug

All trunk and branch and release versions of Thunderbird/suite mailnews/
Composer, and NVU have shown this symptom since the checkin of 2004-02-04



CC'ing author of the patch in question.
QA Contact: bugzilla → editor
Assignee: mozeditor → nobody
bug 649142 fixed this
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.