247968 - download manager doesn't reflect file rename on save

Status: RESOLVED FIXED

(Camino Graveyard :: Downloading, defect)

Description

[Asa Dotzler [:asa]]

When I download a file by doing a Download Link Target... and in the Save dialog
I change the name of the file, say from Camino.dmg.gz to Camino-branch.dmg.gz,
the downloaded file appears with the correct name on my desktop but the Download
manager reports the original file name from the server. 

This was tested with several downloads, all .dmg.gz and all from http servers in
the Mozilla mirrors round-robbin. The Camino build was 2004061708 from the 0.8
branch.

Comment 1

[Asa Dotzler [:asa]]

I've investigated a bit further and this also impacts ftp downloads and is not
limited to the dmg.gz filetype. It seems to be a general problem impacting all
downloads.

Let me know if there's anything more I should test.

Comment 2

[Josh Aas]

Taking. I have a fix, patch coming up soon. We're getting the display name by
taking the last component of the source path. Just change it to destination path.

Comment 3

[Josh Aas]

Attachment: one liner v1.0

Comment 4

[Steve Hartwell]

r=[e-mail] (Steve Hartwell)

This patch seems correct to me.  The display name should indeed be the last path
component of the destination file name.  Did some cursory checks for possible
nilness, found nothing likely.

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 151577 [details] [diff] [review]
one liner v1.0

sr=pink

Comment 6

[Mike Pinkerton (not reading bugmail)]

landed on trunk.

Comment 7

[Mike Pinkerton (not reading bugmail)]

landed on branch