247998 - Group by clauses need to have all columns listed for db independence

Status: RESOLVED DUPLICATE of bug 174295

(Bugzilla :: Bugzilla-General, defect)

Description

[David Lawrence [:dkl]]

Group by clauses need to have all columns listed that are not part of an
aggregate function for better database independence. For example current SQL
resembles:

SendSQL("SELECT products.name,description,disallownew,
                    votesperuser,maxvotesperbug,votestoconfirm,COUNT(bug_id)
             FROM products LEFT JOIN bugs ON products.id = bugs.product_id
             GROUP BY products.name
             ORDER BY products.name");

Change to:

SendSQL("SELECT products.name,description,disallownew,
                    votesperuser,maxvotesperbug,votestoconfirm,COUNT(bug_id)
             FROM products LEFT JOIN bugs ON products.id = bugs.product_id
             GROUP BY products.name, description, disallownew, votesperuser,
maxvotesperbug, votestoconfirm
             ORDER BY products.name");

I have patch and will attach when bug is submitted. I will also make this bug a
blocker of the PostgreSQL support bug.

Comment 1

[David Lawrence [:dkl]]

Attachment: Group by conversion patch

Comment 2

[Joel Peshkin]

make sure you try this with some derived fields (timetracking stuff)

Comment 3

[Dave Miller [:justdave]]

*** This bug has been marked as a duplicate of 174295 ***

*** This bug has been marked as a duplicate of 174295 ***