248021 - Incorrect ordering for tab and window menu items on the File menu

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P5)

Description

[Asa Dotzler [:asa]]

The File menu currently looks like this:

New Window
New Tab
Open File...
Close Tab
Close Window
-----------
Save Page As...
Send Page...
-----------
Page Setup...
Print
-----------
Import...
Work Offline

Notice how the Window and Tab order isn't consistent? It should be this:

New Window
New Tab
Open File...
Close Window
Close Tab
-----------
Save Page As...
Send Page...
-----------
Page Setup...
Print
-----------
Import...
Work Offline

This is inconsistent with every other tab-capable browser I've checked.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: switch positions (and little whitespace fix)

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 157275 [details] [diff] [review]
switch positions (and little whitespace fix)

don't futz with whitespace outside of the area of the patch, its just makes cvs
blame more problematic, please attach a new patch with just the fix needed,
thanks.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: corrected patch

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 157556 [details] [diff] [review]
corrected patch

better ;)

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 157556 [details] [diff] [review]
corrected patch

a=asa for checkin to aviary. Thanks guys.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Can someone check this in? I don't have cvs access.

Comment 7

[Kenneth Herron]

Checked in on the aviary branch:

Checking in browser-menubar.inc;
/cvsroot/mozilla/browser/base/content/browser-menubar.inc,v  <-- 
browser-menubar.inc
new revision: 1.19.2.2.2.30; previous revision: 1.19.2.2.2.29

Should this be checked in on the trunk too?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #7)
> Should this be checked in on the trunk too?

I don't see why it shouldn't, it is a minor change. Maybe I'm missing something.

Comment 9

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040925
Firefox/0.10

confirming fixed on aviary


ps: keyword "fixed-aviary1.0" missing

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Oops, not in on trunk.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Fixed by branch landing.