Closed
Bug 248021
Opened 20 years ago
Closed 20 years ago
Incorrect ordering for tab and window menu items on the File menu
Categories
(Firefox :: Menus, defect, P5)
Firefox
Menus
Tracking
()
VERIFIED
FIXED
People
(Reporter: asa, Assigned: Gavin)
References
()
Details
(Keywords: fixed-aviary1.0)
Attachments
(1 file, 1 obsolete file)
1.57 KB,
patch
|
mconnor
:
review+
asa
:
approval-aviary+
|
Details | Diff | Splinter Review |
The File menu currently looks like this: New Window New Tab Open File... Close Tab Close Window ----------- Save Page As... Send Page... ----------- Page Setup... Print ----------- Import... Work Offline Notice how the Window and Tab order isn't consistent? It should be this: New Window New Tab Open File... Close Window Close Tab ----------- Save Page As... Send Page... ----------- Page Setup... Print ----------- Import... Work Offline This is inconsistent with every other tab-capable browser I've checked.
Reporter | ||
Updated•20 years ago
|
Assignee | ||
Comment 1•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #157275 -
Flags: review?(mconnor)
Assignee | ||
Updated•20 years ago
|
Attachment #157275 -
Flags: review?(mconnor) → review?(firefox)
Comment 2•20 years ago
|
||
Comment on attachment 157275 [details] [diff] [review] switch positions (and little whitespace fix) don't futz with whitespace outside of the area of the patch, its just makes cvs blame more problematic, please attach a new patch with just the fix needed, thanks.
Attachment #157275 -
Flags: review?(firefox) → review-
Assignee | ||
Comment 3•20 years ago
|
||
Attachment #157275 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #157556 -
Flags: review?(mconnor)
Comment 4•20 years ago
|
||
Comment on attachment 157556 [details] [diff] [review] corrected patch better ;)
Attachment #157556 -
Flags: review?(mconnor)
Attachment #157556 -
Flags: review+
Attachment #157556 -
Flags: approval-aviary?
Reporter | ||
Comment 5•20 years ago
|
||
Comment on attachment 157556 [details] [diff] [review] corrected patch a=asa for checkin to aviary. Thanks guys.
Attachment #157556 -
Flags: approval-aviary? → approval-aviary+
Assignee | ||
Comment 6•20 years ago
|
||
Can someone check this in? I don't have cvs access.
Whiteboard: [needs to be checked in]
Comment 7•20 years ago
|
||
Checked in on the aviary branch: Checking in browser-menubar.inc; /cvsroot/mozilla/browser/base/content/browser-menubar.inc,v <-- browser-menubar.inc new revision: 1.19.2.2.2.30; previous revision: 1.19.2.2.2.29 Should this be checked in on the trunk too?
Assignee | ||
Updated•20 years ago
|
Whiteboard: [needs to be checked in]
Assignee | ||
Comment 8•20 years ago
|
||
(In reply to comment #7) > Should this be checked in on the trunk too? I don't see why it shouldn't, it is a minor change. Maybe I'm missing something.
Comment 9•20 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040925 Firefox/0.10 confirming fixed on aviary ps: keyword "fixed-aviary1.0" missing
Assignee | ||
Updated•20 years ago
|
Assignee | ||
Comment 10•20 years ago
|
||
Oops, not in on trunk.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•20 years ago
|
Assignee: firefox → gavin_sharp+bugzilla
Status: REOPENED → NEW
Priority: -- → P5
Assignee | ||
Comment 11•20 years ago
|
||
Fixed by branch landing.
Status: NEW → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•19 years ago
|
Status: RESOLVED → VERIFIED
Updated•18 years ago
|
QA Contact: bugzilla → menus
You need to log in
before you can comment on or make changes to this bug.
Description
•