248046 - nsISignatureVerifier does not belong in CAPS

Status: RESOLVED WORKSFORME

(Core :: Security: CAPS, defect)

Description

[Darin Fisher]

nsISignatureVerifier is used by Necko (for digest auth), mailnews, OJI, GFX
postscript layer, and xpinstall.  It is implemented by PSM.  However, CAPS
doesn't make use of it.  IIRC it was put in CAPS for lack of a better place.

It should really be moved to some more generic location.

One choice would be to move it into Necko, but that seems odd.  There are other
PSM interfaces that live in Necko for lack of a better place.  Perhaps we should
come up with a better place for such interfaces.

Here's a few other security interfaces that exist (for some strange reason) as
part of Necko:

  nsISecretDecoderRing.idl
  nsISecureBrowserUI.idl
  nsISecurityEventSink.idl

I propose moving all of these interfaces under security/manager/idl or
security/idl.  Or, is there some good reason not to do that?

Comment 1

[Darin Fisher]

security/public or security/manager/public seem like good (better?) choices.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

nsICryptoFIPSInfo.idl doesn't sound like it belongs into necko either...

note bug 53648 comment 0. although, security/manager != security/base...

Comment 3

[timeless]

some of those that require it are tier_9 or thereabouts, security is what, tier_40?

if you want the build to break, by all means, move them.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

oh, something else... --disable-crypto should probably not cause the build to
fail. especially as it's the default.

Comment 5

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Moved to security/manager/ssl/public and probably being removed or replaced by bug 805305.