Closed
Bug 248102
Opened 20 years ago
Closed 20 years ago
Splashscreen mozilla.bmp is removed during Upgrade
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Alexander_Pircher, Assigned: mkaply)
Details
(Keywords: fixed1.7.5)
Attachments
(1 file)
595 bytes,
patch
|
ssu0262
:
review+
dveditz
:
superreview+
asa
:
approval1.7.5+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.7) Gecko/20040616 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.7) Gecko/20040616 During Upgrade (Moz 1.6 de-AT to Moz 1.7 de-AT) with Installer the Splashscreen mozilla.bmp is removed. Reproducible: Always Steps to Reproduce: 1. Install Mozilla 1.6 de-AT 2. Upgrade with Installer to Mozilla 1.7 de-AT 3. Actual Results: Installer should not remove the Splashscreen mozilla.bmp Expected Results: Removed mozilla.bmp
Comment 1•20 years ago
|
||
I think this is wanted, anyway the installer asks you if you want to delete the files that are still in the folder you want to install to. But you should always install Mozilla in a clean folder. btw: There is no installer for 1.7 de-AT yet...so you must have used another installer than the unofficial one from http://germaninstaller.sourceforge.net/ :)
Reporter | ||
Comment 2•20 years ago
|
||
I used the original Mozille 1.7-Installer and afterwards installed the languagepack via de-AT-XPI. It didn't know if it is useful to specify also this. However, during installation the warning says "Unrecognized 3rd party components will be removed from this directory to prevent version incompatibilities and will have to be re-installed. ..." IMO should mozilla.bmp be a recognized component and therefore not be removed.
Comment 3•20 years ago
|
||
I think this bug should be invalid, because we don't know what files are "good" and what are "evil" and can be kept. So we do this file deletion in the folder you install in.
Reporter | ||
Comment 4•20 years ago
|
||
There must be already a list of "good" files, because it says "Unrecognized 3rd party components". So why don't make the Splashscreen recognizeable?
Both Frank and Alex are right. Frank because this is the consequence of bug 210731. There it was decided that basically the entire moz folder needs to be cleared except for file: install_status.log dir: plugins dir: uninstall And Alex because I think mozilla.bmp can be qualified as a "good" file, which makes this a valid bug -> Confirming.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 6•20 years ago
|
||
Add mozilla.bmp to the exclude list.
Assignee | ||
Updated•20 years ago
|
Assignee: general → mkaply
Status: NEW → ASSIGNED
Assignee | ||
Updated•20 years ago
|
Attachment #151464 -
Flags: review?(ssu0262)
Comment on attachment 151464 [details] [diff] [review] Fix are there any other files besides just mozilla.bmp? r=ssu, if mozilla.bmp is the only one.
Attachment #151464 -
Flags: review?(ssu0262) → review+
Reporter | ||
Comment 8•20 years ago
|
||
Sean, didn't recognize any other things missing after the upgrade, except the usual 3rd party components.
Attachment #151464 -
Flags: superreview?(dveditz)
Comment 9•20 years ago
|
||
Comment on attachment 151464 [details] [diff] [review] Fix sr=dveditz
Attachment #151464 -
Flags: superreview?(dveditz) → superreview+
Assignee | ||
Comment 10•20 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 11•20 years ago
|
||
Just upgraded from 1.7 to 1.7.3, mozilla.bmp has been removed again. Was the fix checked in into 1.7.3 or before?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 12•20 years ago
|
||
Comment on attachment 151464 [details] [diff] [review] Fix after 1.7, 1.7.x so far have all been security releases, so even if it was on the branch (which it wasn't), it wouldn't have made it into the release. you could try 1.8a5, it should work there.
Attachment #151464 -
Flags: approval1.7.x?
Comment 13•20 years ago
|
||
this is fixed on trunk: mozilla/xpinstall/packager/windows/config.it 1.142
Status: REOPENED → RESOLVED
Closed: 20 years ago → 20 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
Comment 14•20 years ago
|
||
Comment on attachment 151464 [details] [diff] [review] Fix a=asa for 1.7.x checkin.
Attachment #151464 -
Flags: approval1.7.x? → approval1.7.x+
Assignee | ||
Updated•20 years ago
|
Keywords: fixed1.7.x
You need to log in
before you can comment on or make changes to this bug.
Description
•