24823 - The top of a bug description should have last modified date

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect, P3)

Description

[Alan S. Jones]

There are often bugs that I watch, but am not CCed.  Many of these bugs may have 
several comments.  I would be nice to have a the top of a bug description next 
to the bug number a last updated field and/or a last commented filed.

This would keep one from scrolling down though the comments just to find the bug 
had not been changed in 2 months.

Last updated field: is last time any thing on the bug changed (priority, 
component, ect...)

Last Commented field is the last time a text comment was added in the additional 
comments section.

The last comments ones is the one i would rather have, but either or both would 
be hepful.

Comment 1

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 2

[Jesse Ruderman]

You could use a query: list the bug numbers you want to watch in the "include" 
field, click "change columns", add "changeddate", and then sort the query 
by "changeddate".

Comment 3

[Stephan Niemz]

Adding default QA contact to all open Webtools/Bugzilla bugs lacking one.
Sorry for the spam.

Comment 4

[Andreas Franke (gone)]

-> Bugzilla product, IMO mostly UI question, reassigning.

Comment 5

[Dave Miller [:justdave]]

setting default owner

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Makes sense.  This might be part of a general redesign of the "show bug" screen.

Comment 7

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 8

[Eric Hodel]

While implementing last-modified for the bug report, why not send the HTTP
header as well?

Comment 9

[Vaskin Kissoyan]

I'm submitting my first patch here... so let me know what you think.

I have added in this feature using the lastdiffed column in the bug table. I've
done my work on the "TIP" / trunk as you guys call it and I did updates fairly
recently so these patches should be good.

I had to modify default templates and also used table changes to right-align the
date. (perhapse over-stepped my bounds, but it looked like crap at first)

I also fixed a spot where the non-filtered version of the short_desc was still
being displayed, just noticed it there and fixed it, if it was that way for a
reason, that should be backed out. see "filtered_desc" change in
edit.html.tmpl.patch

Comment 10

[Vaskin Kissoyan]

Attachment: my stab at a patch for Last Modified

here are the three files that I modified. Again these are very recent edits
done against the tip.

Comment 11

[Vaskin Kissoyan]

Attachment: bug_form.pl.patch

made provisions for pulling in the lastdiffed column from the bugs table

Comment 12

[Vaskin Kissoyan]

Attachment: edit.html.tmpl.patch

fixed a filtered_desc that was setup, but not used and also added h3 for the
bug.lastdiffed value so we can pass to the header template

Comment 13

[Vaskin Kissoyan]

Attachment: headler.html.tmpl.patch

set default last modified, add in extra table data for the right-aligned last
modified date

Comment 14

[Dave Miller [:justdave]]

Comment on attachment 87445 [details] [diff] [review]
bug_form.pl.patch

Should be using delta_ts and not lastdiffed.  delta_ts is the modified
timestamp on the bug, lastdiffed is the timestamp for when mail was last sent
about the bug, which depending on the preferences of all the people on the bug,
might not be the same.

Comment 15

[Dave Miller [:justdave]]

Comment on attachment 87447 [details] [diff] [review]
edit.html.tmpl.patch

we should probably make this a little more generic for the purpose of the
header template and make h3 a generic text field.  Pass in the "Last Modified:
" with the date as an entire string from bug/edit.html.tmpl

Comment 16

[Dave Miller [:justdave]]

Comment on attachment 87450 [details] [diff] [review]
headler.html.tmpl.patch

needs-work: See reasons from the previous patch.  We should pass in the "Last
Modified: " bit, too, instead of assuming h3 will contain a modification date.

Comment 17

[Vaskin Kissoyan]

Attachment: patch v2

Sorry about the 3-part previous patch. I believe I've addressed everything that
needed work. 

Apparently delta_ts is the correct value to display.

No longer using lastdiffed, delta_ts is the correct field in bugs table to
display.

I used some formatting code in bug_form and applied it to the value since it
was not displayable in its database format which cannot use the date_format()
function.  (Apparently the 2 _ts fields are diff data types in MySQL one that
can use the date_format, and one that cannot) I used a simple substring code to
derive the display value in bug_form.pl. 

The value text value "Last Modified: " is appended in edit.html.tmpl and passed
to header.html.tmpl which then right-aligns the h3 TD displaying the value to
the user.

Comment 18

[Dave Miller [:justdave]]

Comment on attachment 88084 [details] [diff] [review]
patch v2

This patch no longer applies to the tip cleanly.  However, it only had one
conflict and was easy to fix.

Also, the title doesn't need to be filtered in edit.html.tmpl because
header.html.tmpl does the filtering there.

Comment 19

[Dave Miller [:justdave]]

Attachment: Patch v3 - Vaskin's patch with review comments fixed

Comment 20

[Dave Miller [:justdave]]

Comment on attachment 94736 [details] [diff] [review]
Patch v3 - Vaskin's patch with review comments fixed

wtf did I come up with that name?  Sorry about that.  Vaskin, not Vladimir

Comment 21

[Dave Miller [:justdave]]

reassing to patch author

Comment 22

[Dave Miller [:justdave]]

Comment on attachment 94736 [details] [diff] [review]
Patch v3 - Vaskin's patch with review comments fixed

inheriting my r= from the previous patch, but since I slightly modified the
patch, need a 2nd r= from someone else

Comment 23

[Bradley Baetz (:bbaetz)]

Comment on attachment 94736 [details] [diff] [review]
Patch v3 - Vaskin's patch with review comments fixed

There are tabs, and the header.tmpl.html comment shouldn't refer to this
specific use - other places may use it in the future.

Comment 24

[Vaskin Kissoyan]

Attachment: proposed patch v4

Ok,

I've fixed a major issue with the other patches which was that they would mung
delta_ts and cause all edits to the bug to throw a Mid-Air collision (complete
app showstopper). 

I implemented my changes with an alias column on the original sql statement
called calc_disp_date, which then is used only for displaying this date. I
don't know if there is a reasoable way to do this through the TT formatting
since it probably doesn't understand the format used for the delta_ts field.
However if someone does know how to do that, it might be preferable rather than
using an alias field in the sql statement, which is kind-of messy.

I've ammended the comments to more generally describe what h3 is for.
"Right-aligned subheader."

Comment 25

[Gervase Markham [:gerv]]

I think that, like the potential moving of the CC field that we've discussed
recently, this should wait for the redesign of show_bug - for exactly the same
reasons. If we are going to change the UI of this page, we should (as far as
possible) do it in one go.

Gerv

Comment 26

[Dave Miller [:justdave]]

OK, but don't we need to make sure that the person doing the redesign knows this
field needs to be factored in?  Since this is a completely new piece of UI, I
don't think the redesign applies here.  If we don't put this in, it won't be
there to move in the redesign.

Comment 27

[Bradley Baetz (:bbaetz)]

Yeah,I don't think that this is getting in the way of the mythical resdesign

Comment 28

[Bradley Baetz (:bbaetz)]

Comment on attachment 94854 [details] [diff] [review]
proposed patch v4

IF we keep waiting for redesigns, nothing will ever get done

Note that you still have a tab (the last chunk of the patch, for the   td)

Whever applies this should fix that, or I'll check it in later this afternoon
when I find a clean tree

r=bbaetz x2

Comment 29

[Vaskin Kissoyan]

Attachment: proposed patch v5

Brought it into sync with current HEAD since there were conflicts since a
recent commit. Hopefully I took out the annoying tab.

Comment 30

[Bradley Baetz (:bbaetz)]

Comment on attachment 95042 [details] [diff] [review]
proposed patch v5

Theres still one more tab, but I've removed that locally

r=bbaetz

Comment 31

[Bradley Baetz (:bbaetz)]

and checked in, thanks

Comment 32

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/84b66e697063
[fenix] Fixes 24823: remove recent synced tab when logged out