248267 - newsgroup subscribe window: search result unsorted and unsortable

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[David Robin]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040621
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040621

When search for "kern" newsgroup on news.gmane.org, results are not sorted.
When click on "newsgroups name" column in order to sort filtered newsgroups, I
don't get any sorting.
I expect this behaviour to be the same with any news server.

Reproducible: Always
Steps to Reproduce:
1. create an account on news.gmane.org
2. open the "subscribe" window
3. enter "kern" in search field.
4. try to sort results.

Actual Results:  
Nothing.

Expected Results:  
Result of the search step should be sorted.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Confirming.

This was _supposed_ to be fixed in bug 87928, but was never implemented for the
search view ;-(

Comment 2

[Thomas Harold]

Confirmed in Mozilla 1.7 on Windows XP.

Using the GigaNews UseNet service, searching for all items that contain
"mozilla".  Most of the list is sorted, but clicking on the newsgroup name
column header does nothing to affect the sort order.

(This bug seems similar to Bug 87928, except that it's still broken.)

Comment 3

[[e-mail]]

Attachment: Reverse sort by name only

Reversing the list is the best I could do.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Neil?  Did you intend for review requests to be set?

Comment 5

[[e-mail]]

Comment on attachment 154769 [details] [diff] [review]
Reverse sort by name only

I just realized I forgot to diff the .h :-[ well, I hope you can guess what it
says ;-)

Comment 6

[David :Bienvenu]

Comment on attachment 154769 [details] [diff] [review]
Reverse sort by name only

+	 if (mSearchResultSortDescending)
+	     element->SetAttribute(dir, NS_LITERAL_STRING("descending"));
+	 else
+	     element->SetAttribute(dir, NS_LITERAL_STRING("ascending"));

this could use the ? operator...

in  nsNntpIncomingServer::SetTree()

are we worried about any of those getters returning a null pointer (and thus
crashing)?

Comment 7

[[e-mail]]

Attachment: Full patch plus addressed review comments

Comment 8

[[e-mail]]

Fix checked in, with a persisted sortDirection as agreed by bienvenu.

Resolving; I think sorting by subscription should be a separate rfe.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2004-08-31-08 on Windows XP (Seamonkey trunk).

Comment 10

[David Robin]

BUG REPORTER says:
"Bug fixed on linux home build :
    Mozilla 1.8a4
    Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a4) Gecko/20040908"