248280 - pref "javascript.allow.mailnews" is obsolete and should be removed

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Henrik Gemal]

currently it's in:
http://lxr.mozilla.org/mozilla/source/modules/libpref/src/init/all.js#422
it should be moved to a mailnews specific .js file

Comment 1

[Magnus Melin [:mkmelin]]

The pref is now obsolete, and should be removed - see bug 504965 comment 8.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: comm-central proposed fix

Removing the dead ui from seamonkey. You may want to figure out how much sense it makes to have the single [ ] Browser section there and such, but let's leave that to another bug.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: mozilla-central proposed fix

dmose, want to review the m-c patch? dunno who would be a good reviewer for something like this, but as you're the one who implemented the removal of the pref...

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 396141 [details] [diff] [review]
mozilla-central proposed fix

r=dmose; thanks for the patch!

Comment 5

[Magnus Melin [:mkmelin]]

mozilla-central part checked in
changeset:   31791:8e21c74914f7
http://hg.mozilla.org/mozilla-central/rev/8e21c74914f7

Comment 6

[Karsten Düsterloh]

Comment on attachment 396140 [details] [diff] [review]
comm-central proposed fix

Thanks for caring!

Comment 8

[Magnus Melin [:mkmelin]]

changeset:   3545:6169983ce2ac
http://hg.mozilla.org/comm-central/rev/6169983ce2ac

->FIXED

Comment 9

[Robert Kaiser]

Adding fixed-seamonkey2.0 keyword so the queries for approved but not fixed bugs don't catch that bug.

Comment 10

[Robert Kaiser]

(In reply to comment #3)
> Created an attachment (id=396141) [details]
> mozilla-central proposed fix

Should this be landed on 1.9.1/.2 as well? If so, I guess you should request approval. I saw that some users are confused by finding the pref in about:config in SeaMonkey 2.0, thinking it would be any good to set it to true.

Comment 11

[Phillip M. Jones, C.E.T.]

Not confused, hoping against all hope it was hidden switch to turn it on. I've have had JavaScript on since netscape Navigator 3.0.1.a days and have never had any problems with it.

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 396141 [details] [diff] [review]
mozilla-central proposed fix

Dead pref removal to avoid confusion.

Comment 13

[Samuel Sidler (old account; do not CC)]

These bugs landed after b4 was cut. Moving flag out.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 396141 [details] [diff] [review]
mozilla-central proposed fix

approval1.9.2 requests aren't currently being monitored, since we're nearing RC freeze and there are too many outstanding requests, so I'm clearing this request. Feel free to re-request approval if you are confident that it's worth drivers' time to consider whether this non-blocker needs to land for 1.9.2 at this stage.