config.trim_on_minimize no longer works

RESOLVED FIXED

Status

()

Firefox
General
RESOLVED FIXED
14 years ago
13 years ago

People

(Reporter: Robert Parenton, Assigned: Benjamin Smedberg)

Tracking

({fixed-aviary1.0, regression})

unspecified
x86
Windows XP
fixed-aviary1.0, regression
Points:
---
Bug Flags:
blocking-aviary1.0PR -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

(Reporter)

Description

14 years ago
Setting the pref config.trim_on_minimize to false, which was introduced in Bug
76831, no longer works in Firefox, in both branch and trunk builds.  This used
to work, but stopped working sometime after the creation of the Aviary branch. 
Initially after the creation of the branch it worked on both branch and trunk
builds.

Expected behavior is that Mem Usage stays constant in Task Manager upon minimizing.

Actual behavior is that Mem Usage drops in Task Manager upon minimizing.
(Reporter)

Comment 1

14 years ago
Regression occurred in May 18 branch build.  I'll have it narrowed down to the
exact branch checkin and the corresponding trunk checkin soon.
(Reporter)

Comment 2

14 years ago
bsmedberg, your semi-single profile checkin broke the config.trim_on_minimize
code implemented in Bug 76831 comment #275.  For background on this pref and its
effect, see Bug 76831 comment #267, Bug 76831 comment #268, Bug 76831 comment
#281, and Bug 76831 comment #292.

Guilty checkin:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=AVIARY_1_0_20040515_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-05-17+18%3A26%3A00&maxdate=2004-05-17+18%3A26%3A00&cvsroot=%2Fcvsroot

This comment applies to the aviary branch only.  I'll post which checkin broke
it on the trunk and if that trunk checkin broke the pref in Seamonkey at some point.

Comment 3

14 years ago
I can confirm this bug is present in Firefox 0.9. Please bring trim_on_minimize
back, it solves one of the most annoying issues with Mozilla/Firefox, especially
on machines with plenty of RAM.
(Assignee)

Comment 4

14 years ago
This was caused because the new code created the hiddenwindow before the profile
was selected. The client code that reads the pref should really install a pref
observer, instead of relying on magic knowledge of when the hidden window is
going to appear.
Assignee: firefox → bsmedberg
(Assignee)

Comment 5

14 years ago
fixed-on-trunk, still need to land this on the branch
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Whiteboard: needed-aviary1.0
(Reporter)

Updated

14 years ago
Flags: blocking-aviary1.0RC1?

Comment 6

14 years ago
(In reply to comment #5)
> fixed-on-trunk, still need to land this on the branch

Could we get it back on the branch now?  And, should it be marked 'FIXED' if
only the trunk is fixed?

Comment 7

14 years ago
Reopening until fixed on the branch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 8

14 years ago
Could someone please clarify: did this make it into Firefox 0.9.2 ?

Comment 9

14 years ago
Tony - No. The fix isn't yet on the Firefox branch.  0.9.2 wasn't taken from the
current branch code anyway - it was identical to 0.9.1 except for the single
security fix.

When it is actually fixed on the branch, that will be mentioned (in particular,
"fixed-aviary1.0" will be added).  In general, if it's not clear whether
something has happened, it means it hasn't. :-)
(Reporter)

Comment 10

14 years ago
Created attachment 152907 [details] [diff] [review]
Branch version of the patch checked in on the trunk
(Reporter)

Updated

14 years ago
Flags: blocking-aviary1.0?
(Assignee)

Updated

14 years ago
Status: REOPENED → RESOLVED
Last Resolved: 14 years ago14 years ago
Flags: blocking-aviary1.0RC1?
Flags: blocking-aviary1.0RC1-
Flags: blocking-aviary1.0?
Flags: blocking-aviary1.0-
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Whiteboard: needed-aviary1.0
(Reporter)

Updated

14 years ago
Attachment #152907 - Attachment is obsolete: true

Updated

13 years ago
Flags: blocking-aviary1.0- → blocking-aviary1.0?

Comment 11

13 years ago
No point in nominating a bug that's already been fixed.
Flags: blocking-aviary1.0?
You need to log in before you can comment on or make changes to this bug.