248432 - unable to uninstall extensions which have not finished downloading

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[phrostypoison]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040614 Firefox/0.9 (Firefox/0.9)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040614 Firefox/0.9

When downloading an extension (e.g.: Firefox Help Viewer) and the connection
cuts off suddenly,the download is stopped but Firefox regards the incomplete
download as an installed extension.

Reproducible: Always
Steps to Reproduce:
1. Download an extension that installs itself automatically.
2. Before finishing the download, terminate the connection.
3. Uninstall the partly-downloaded extension.

Actual Results:  
nothing, and the item in the extensions manager stays indefinitely.

Expected Results:  
The extension is removed, or when cut-off, not installed.

Firefox error console reported: "*** getItemProperty failing for lack of an
item. This means _getResourceForItem failed to locate a resource for aItemID
(/pub/mozilla.org/extensions/firesomething/firesomething.xpi)"

Comment 1

[phrostypoison]

The error returned was when uninstalling an unfinished downloaded duplicate of
firesomething.

Comment 2

[Asa Dotzler [:asa]]

I can reproduce this on windows XP after a failed download of All in One
Gestures on today's (20040831) branch build. Now the listing cannot be removed
even though the uninstall says it will be removed after a restart. 

I expect that server slowdown, internet congestion, or any number of other
circumstances could put lots of users into this condition. 

Comment 3

[chris hofmann]

lets get this by final

Comment 4

[Grey Nicholson (they/them)]

I'm getting *all* extensions refusing to uninstall (using 20040922) after a
restart of both Firefox and Windows.

Several previous nightlies would only uninstall an extension if I: set the
extension to uninstall, restarted Firefox, then attempted to reinstall the
extension.

Comment 5

[Grey Nicholson (they/them)]

(In reply to comment #4)
> I'm getting *all* extensions refusing to uninstall (using 20040922) after a
> restart of both Firefox and Windows.
> 
> Several previous nightlies would only uninstall an extension if I: set the
> extension to uninstall, restarted Firefox, then attempted to reinstall the
> extension.

I've now managed to uninstall an extension using 20040922, but only by
reinstalling the extension when it's set to uninstall.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

make sure we can clean up cancelled dl entries.