248435 - CERT_DecodeGeneralName not in public header file

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

The fix for bug 122712 exported CERT_DecodeGeneralName among other symbols,
but it left the declaration of that function in a private header file.

This has apparently been blocking progress on PSM bug 230655 since February.
But apparently, John didn't file an NSS bug about this.  :(

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Nominating this for 3.9.3

Comment 2

[Wan-Teh Chang]

Moved to 3.10, unless Julien wants the fix in 3.9.4.

Comment 3

[Wan-Teh Chang]

Attachment: Proposed patch

Moved the declarations of CERT_DecodeGeneralName
and CERT_EncodeGeneralName (also exported) from
the private header genname.h to the public header
cert.h.

xconst.c uses these two functions and therefore
needs to include cert.h now.

Comment 4

[Wan-Teh Chang]

Patch checked in on the NSS trunk (NSS 3.10).

Checking in cert.h;
/cvsroot/mozilla/security/nss/lib/certdb/cert.h,v  <--  cert.h
new revision: 1.48; previous revision: 1.47
done
Checking in genname.h;
/cvsroot/mozilla/security/nss/lib/certdb/genname.h,v  <--  genname.h
new revision: 1.9; previous revision: 1.8
done
Checking in xconst.c;
/cvsroot/mozilla/security/nss/lib/certdb/xconst.c,v  <--  xconst.c
new revision: 1.8; previous revision: 1.7
done