248527 - Open In New Tabs leaves blank initial tab

Status: RESOLVED WONTFIX

(Camino Graveyard :: Tabbed Browsing, defect, P3)

Description

[Steve Abrahamson]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040623 Camino/0.8
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040623 Camino/0.8

The tab interface is only available when one or more window(s) is/are open. To
open a tab set with no windows open, the user must first open a window, then
select the tab set to open. This is fine.

However, Camino should look at the currennt window's contents, and if empty,
replace that with the tab set. That is, if there are 7 bookmarks in the the tab
sets, the user should end up with 7 tabs, not 8 (the first one being blank).
Very idd behavior.

Reproducible: Always
Steps to Reproduce:
1. Open a new window
2. Select a tab set to open
3. See how you have an extra empty tab in your way before you can get to what
you asked for.

Actual Results:  
I had to wonder 1) why did I have more tabs than I asked for, and 2) why was the
screen still blank?

Expected Results:  
Evaluated the contents of the frontmost window/tab. If empty, delete it or
replace it with the tabs requested.

Comment 1

[Stuart Morgan]

I think the real issue here is that we aren't very consistant about "Open in
Tabs" vs. "Open in New Tabs". Some things (dragging a toolbar folder, tab groups
(I think)) replace existing content, whereas others (BM context menus) only
allow Open in New Tabs. We should either pick one and always do it, or allow
both whenever possible.

The behavior as described in this bug is probably correct as things are now (it
is Open in *New* Tabs), but our tab bookmark behavior is inconsistant and confusing.

Comment 2

[Jasper]

I have nver seen this so I can not confirm, I need much more information.
Reporter please give as much info as you have.

What bookmarks (urls)?
Do you have separators there?
....

Comment 3

[Peter Yang]

Confirmed in Camino nightly 2004101808.

- Open a new window.
- Find a bookmark folder on your bookmark bar, control-click it, and select
"Open in New Tabs."
- If I did that to a folder with 5 bookmarks, six tabs are present at the top.
The second tab is active and contains the first bookmark in the folder. The
first tab is blank.

Comment 4

[Jasper]

Ok got it over to Geoff.

New steps:
- open a new window
- open a bookmark folder on the bookmark bar using "Open in new Tabs"
- all bookmarks are opened in tabs + 1

Comment 5

[Geoff "temporarily off bugmail" Beier]

(In reply to comment #4)
> Ok got it over to Geoff.
> 
> New steps:
> - open a new window
> - open a bookmark folder on the bookmark bar using "Open in new Tabs"
> - all bookmarks are opened in tabs + 1

This works as expected for me:

1. Open a new window. I have no tabs, and just show my home page.
2. Open a bookmark folder on the bookmark bar containing 3 bookmarks, using
"Open in new tabs". I now have 4 tabs: my homepage + the 3 bookmarks.

This is what "Open in new tabs" should do; I want that option to leave my
current tabs alone and open new ones. Or do I misunderstand this bug?

Comment 6

[Jasper]

Yes you are right Geoff.

I think the issue here is that in all other cases we replace the existing tabs
with new tabs.
And that people do not view a new window as a tab. So we when 3 tabs are added
they end up with 4 tabs which confuses them.

Comment 7

[Dave Miller [:justdave]]

Rescued from the mailbox that catches our bounces:
(for future reference, you need to click the link and add your comments from the
web page)

Date: Mon, 25 Oct 2004 22:59:15 -0500                                          
                                                    
From: Peter Yang <[e-mail]>                                        
                                                    
To: "[e-mail]" <[e-mail]>                
                                                    
Subject: Re: [Bug 248527] Open In New Tabs leaves blank initial tab            
                                                    
                                                                               
                                                    
I don't have a home page, just a blank window. So when I open a                
                                                    
bookmark in tabs, it ignores the current blank window and creates              
                                                    
three new tabs.                                                                
                                                    
                                                                               
                                                    
I guess I would expect it to reuse a blank window.                             
                                                    

Comment 8

[Torben]

Attachment: Reuse window is empty

AFAIUI the issue is that if, and only if, you open a tabgroup in an empty
window (i.e. about:blank) this tab should be reused.

Note that to automatically select the first tab afterwards the test value must
be stored as an integer and not a boolean value.

Comment 9

[Torben]

Attachment: Reuse window if empty, v 1.1

Fixed a possible glitch: added a check to make sure the window is not loading a
page but has not got any content yet, previously it would have bee treated as
empty.

Comment 10

[Simon Fraser [no longer active]]

Suggest WONTFIX. "Open in New Tabs" should do exactly what it says.

Comment 11

[Samuel Sidler (old account; do not CC)]

I agree. If it's "new" tabs, it shouldn't reuse any tabs, even if they're blank.

Comment 12

[Torben]

Comment on attachment 186134 [details] [diff] [review]
Reuse window if empty, v 1.1

This doesn't apply anymore, if someone still wants this let me know and I'll
attach an updated patch.