Closed Bug 248795 Opened 19 years ago Closed 17 years ago

Menu item "Refresh Remote Calendars" should be disabled when there are no remote calendars

Categories

(Calendar :: Sunbird Only, defect)

Product:
Calendar
Component:
Sunbird Only
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: Stefan.Borggraefe, Assigned: jminta)

Details

(Keywords: polish)

Attachments

(1 file, 1 obsolete file)

patch v2
9.82 KB, patch
mvl
: first-review+
Details | Diff | Splinter Review 
It's a no-op in this situation and it makes no sense to select it.
QA Contact: gurganbl → sunbird
Attached patch quick and painless (obsolete) — — Splinter Review 
Checks on startup and when calendars are added/removed to see whether there are any remote calendars.  Disables the command when appropriate.
Assignee: mostafah → jminta
Status: NEW → ASSIGNED
Attachment #219484 - Flags: first-review?(mvl)
Comment on attachment 219484 [details] [diff] [review]
quick and painless

Wouldn't it be better to add some capability flags to calICalendar, one of them being 'canReload'? Sombody might write an addressbook based calendar, extracting birthdays. That calender also won't be reloadable. So the hardcoded 'storage' in your patch will fail for those cases.
Attached patch patch v2 — — Splinter Review 
This patch follows the previous comment of adding an idl method for whether or not it makes sense to reload a calendar of that type.
Attachment #219484 - Attachment is obsolete: true
Attachment #224443 - Flags: first-review?(mvl)
Attachment #219484 - Flags: first-review?(mvl)
Comment on attachment 224443 [details] [diff] [review]
patch v2

>+   * Whether or not it makes sense to call refresh() on this calendar.
>+  readonly attribute boolean canReload;

the method is named refresh(), lets call the flag canRefresh, for more clearity. (or even: canBeRefreshed?)

r=mvl with that
Attachment #224443 - Flags: first-review?(mvl) → first-review+
patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060827 Calendar/0.3a2+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.