248795 - Menu item "Refresh Remote Calendars" should be disabled when there are no remote calendars

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Stefan Borggraefe]

It's a no-op in this situation and it makes no sense to select it.

Comment 1

[Joey Minta]

Attachment: quick and painless

Checks on startup and when calendars are added/removed to see whether there are any remote calendars.  Disables the command when appropriate.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 219484 [details] [diff] [review]
quick and painless

Wouldn't it be better to add some capability flags to calICalendar, one of them being 'canReload'? Sombody might write an addressbook based calendar, extracting birthdays. That calender also won't be reloadable. So the hardcoded 'storage' in your patch will fail for those cases.

Comment 3

[Joey Minta]

Attachment: patch v2

This patch follows the previous comment of adding an idl method for whether or not it makes sense to reload a calendar of that type.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 224443 [details] [diff] [review]
patch v2

>+   * Whether or not it makes sense to call refresh() on this calendar.
>+  readonly attribute boolean canReload;

the method is named refresh(), lets call the flag canRefresh, for more clearity. (or even: canBeRefreshed?)

r=mvl with that

Comment 5

[Joey Minta]

patch checked in.

Comment 6

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060827 Calendar/0.3a2+