248847 - redirect_loop.{xul,dtd} seems unused

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

http://lxr.mozilla.org/seamonkey/search?string=redirect_loop

no user of these files. the error seems instead handled in
http://lxr.mozilla.org/seamonkey/source/docshell/base/nsDocShell.cpp#2653, with
the translation in
http://lxr.mozilla.org/seamonkey/source/docshell/resources/locale/en-US/appstrings.properties#44
(and presumably using the promptservice, which I didn't verify)

So, netwerk/resources/content is unused, and
netwerk/resources/locale/en-US/redirect_loop.dtd can be removed as well.

Comment 1

[timeless]

this is probably for pretty errors and just not implemented.


having hit the dialog recently, let me assure you it's fairly annoying (although
i'd be more annoyed by the pretty error page ;-).

Comment 2

[Darin Fisher]

yes, they are unused.  we used to show this to users, but then switched to
showing a dialog.  someday it will be a page again when we support error pages
for real.  but then this content won't be used in that case.  it should have
been removed ages ago.

Comment 3

[Darin Fisher]

fixed-on-trunk

Comment 4

[benc]

V/fixed.
Gone from lxr's tip.