248964 - View Source -> Save As doesn't save file

Status: VERIFIED FIXED

(Core Graveyard :: View Source, defect)

Description

[K Chayka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a2) Gecko/20040627
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a2) Gecko/20040627

The Save function in the View Source window stopped working sometime during the
last 2 weeks of May (WFM in build 051409, doesn't in 053108). Both browser and
mail-news source windows are affected.

My download prefs are set to use progress dialog, but same happens whether using
download manager or no download dialogs at all.

Reproducible: Always
Steps to Reproduce:
1. Pick a page, any page, or any mail message: http://www.mozilla.org/ fer instance
2. CTRL-U, or use View->Source menu option: the View Source window opens
3. CTRL-S, or use File->Save As menu option: the Save dialog opens
4. Pick a file name and location, then OK (or whatever): the Save dialog closes
and the progress dialog opens.

Actual Results:  
Everything just sits there, doing nothing. No file is saved, the progress dialog
never goes away. Have to cancel.


Expected Results:  
Actually saving the file (like it used to) would be dandy.

This bug is a real annoyance.

Comment 1

[K Chayka]

I see that trunk builds from the end of May are still available for download, so
I narrowed down when the problem actually started.

win32 build 052009 works, 052108 doesn't, nor has any build since then worked.

Comment 2

[R.K.Aa.]

same on Linux. I see this error on js console:

Error: XPCNativeWrapper is not defined
Source File: chrome://communicator/content/contentAreaUtils.js
Line: 48

Bug 220215 was fixed in the given timespan and touched XPCNativeWrapper
- adding comment there.

Comment 3

[[e-mail]]

Attachment: Proposed patch

Comment 4

[Doron Rosenberg (IBM)]

Neil, just check it in, no need for sr :)

Comment 5

[jag (Peter Annema)]

Comment on attachment 151933 [details] [diff] [review]
Proposed patch

sr=jag

Comment 6

[[e-mail]]

Comment on attachment 151933 [details] [diff] [review]
Proposed patch

Low-risk patch to fix noticable bug.

Comment 7

[OstGote!]

Patch is still not checked in. 1.8a2 is long ago.

Comment 8

[[e-mail]]

Fix checked in.

Comment 9

[alanjstr]

I saw this on the Aviary bonsai.  Does that mean bug 222157 is not resolved, too?

Comment 10

[alanjstr]

I saw this on the Aviary bonsai.  Does that mean bug 222157 is now resolved, too?

Comment 11

[[e-mail]]

No, FireFox doesn't use this file.

Comment 12

[K Chayka]

win32 build 081109

WFM

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with build 2004-08-23-08, Trunk Seamonkey on Windows XP.