Closed
Bug 249231
Opened 21 years ago
Closed 21 years ago
Use only "web site" and "web page" in Firefox
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox1.0beta
People
(Reporter: jwalden+fxhelp, Assigned: jwalden+fxhelp)
References
()
Details
(Keywords: fixed-aviary1.0, Whiteboard: [have patch])
Attachments
(1 file, 3 obsolete files)
|
25.07 KB,
patch
|
mconnor
:
review+
chofmann
:
approval-aviary+
|
Details | Diff | Splinter Review |
Several weeks ago a checkin (I believe only to trunk) switched Seamonkey over to
"website" from "web site" (see bug at referenced UI). I thought Firefox only
used "Web site", as that's what I'd seen in Options and other places. However,
I just noticed the popup notification icon tooltip has "website" in it. A few
text searches show that there's some split in usage (even within a dialog in one
instance), as evidenced by a small sample of links:
"web site":
http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/chrome/browser/cookieviewer/CookieExceptions.dtd#7
http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/chrome/browser/pref/pref-advanced.dtd#27
http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/chrome/browser/pref/pref-advanced.dtd#91
"Web site":
http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/chrome/browser/pref/pref-features.dtd#12
http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/chrome/browser/pageReportFirstTime.dtd#1
All of Firefox Help (standardized per my understanding that "Web site" was the
consistent choice)
"website":
http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/chrome/browser/browser.dtd#328
http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/chrome/browser/pref/pref-advanced.dtd#8
http://lxr.mozilla.org/aviarybranch/source/toolkit/components/passwordmgr/resources/locale/passwordmgr.properties#41
http://lxr.mozilla.org/aviarybranch/source/browser/locales/en-US/chrome/browser/cookieviewer/CookieExceptions.dtd#8
Firefox needs to standardize on one of "web site", "Web site", or "website".
It's (very mildly) confusing, and there's no reason not to make everything look
the same. I prefer "website" as it's vastly more common according to a Google
search for each. (Interestingly, "website" is actually recommended as a
misspelling of "web site".)
All I need by way of response to this bug is a response from devs as to which
(website/Web site/web site) is the one wanted. At that point I'll assign the
bug to myself and start on a patch. I can and will make patches for the trunk
and the aviary branch with the required changes, which should be a simple (if
possibly lengthy) task. I don't have the time to do anything until after July,
but I can and will get it done before 1.0 because it's a niggly polish issue.
| Assignee | ||
Comment 1•21 years ago
|
||
I'm requesting blocking-aviary1.0? to get a response to my question. If I get a
response early enough, I will create a patch, so this *will* be fixed by 1.0.
Also, in the first paragraph of my last comment, it should be "see bug at
referenced URI". Oops. ;-)
Flags: blocking-aviary1.0?
Comment 2•21 years ago
|
||
"web page(s)" / "Web page(s)" is a similar problem.
Updated•21 years ago
|
Flags: blocking-aviary1.0RC1-
| Assignee | ||
Comment 4•21 years ago
|
||
Well, I was definitely hoping more for "website" as uncapitalized and
single-word seems to be the dominant form now, but as long as it's standardized
I guess I'm okay with it. Patch coming up (which also addresses the similar
situation with "webpage")...
Status: NEW → ASSIGNED
Summary: Use only one of "web site", "Web site", or "website" in Firefox → Use only "web site" and "web page" in Firefox
| Assignee | ||
Comment 5•21 years ago
|
||
A series of greps has gotten this as close to complete as I can determine it.
The new usage as defined by the patch is "web site" and "web page".
Assignee: firefox → jwalden+fxhelp
| Assignee | ||
Comment 6•21 years ago
|
||
Comment on attachment 155340 [details] [diff] [review]
Convert website/page to two-word, no-caps usage - should be complete
Requesting review from Blake on this...
Let me know if I should pass this review to someone else, because I'd really
like to get it in before the localization freeze (or else it won't get in until
after 1.0).
Attachment #155340 -
Flags: review?(firefox)
| Assignee | ||
Comment 7•21 years ago
|
||
The last patch had an extra set of changes for another bug. I'll be switching
the review in a sec...
Attachment #155340 -
Attachment is obsolete: true
| Assignee | ||
Updated•21 years ago
|
Attachment #155345 -
Flags: review?(firefox)
| Assignee | ||
Updated•21 years ago
|
Attachment #155340 -
Flags: review?(firefox)
Comment 8•21 years ago
|
||
Comment on attachment 155345 [details] [diff] [review]
Same as previous with extraneous changes removed
r=rlk@trfenv.com for the help content. Ben, can you review this for 1.0rc1?
Attachment #155345 -
Flags: superreview?(bugs)
Attachment #155345 -
Flags: review?(firefox)
Attachment #155345 -
Flags: review+
Comment 9•21 years ago
|
||
Ben, this is a locale change and the locale freeze is 1.0 RC 1. Since there is a
patch, I recommend reconsidering this.
Flags: blocking-aviary1.0PR- → blocking-aviary1.0PR?
| Assignee | ||
Comment 10•21 years ago
|
||
The previous patch (attachment 155345 [details] [diff] [review]) now generates a bunch of prompts when
applied to a tree. This patch is updated so that it'll apply without requiring
answers to any prompts. Nothing in Help code has been changed in this patch
that wasn't changed in the previous one, so rlk's r+ still applies to the Help
stuff.
| Assignee | ||
Updated•21 years ago
|
Attachment #155345 -
Attachment is obsolete: true
| Assignee | ||
Comment 11•21 years ago
|
||
Comment on attachment 156001 [details] [diff] [review]
Patch updated to latest aviary branch cvs
Last I heard, blake was working through the UI text review bug list, and ben
always seems busy. Hence, requesting review from blake...
Attachment #156001 -
Flags: review?(firefox)
| Assignee | ||
Comment 12•21 years ago
|
||
Comment on attachment 155345 [details] [diff] [review]
Same as previous with extraneous changes removed
Removing review request from the patch that's now prompt-hindered when applied
to aviary...
Attachment #155345 -
Flags: superreview?(bugs)
Comment 13•21 years ago
|
||
lets get reviews and checked in soon if all looks well..
Flags: blocking-aviary1.0PR? → blocking-aviary1.0PR+
Whiteboard: [have patch]
Comment 14•21 years ago
|
||
(In reply to comment #11)
> (From update of attachment 156001 [details] [diff] [review])
> Last I heard, blake was working through the UI text review bug list, and ben
> always seems busy. Hence, requesting review from blake...
>
from my experience, ben is faster than blake. But blake does seem more active in
Firefox than previously so I could be wrong.
Comment 15•21 years ago
|
||
I think we should at least check in the Help part, because we've changed that in
other places in Help.
| Assignee | ||
Comment 16•21 years ago
|
||
A few files were removed that the patch changed, so the patch would have
failed. This patch (unlike the last few patches) also has enough context to be
fully reversible. Will try Ben for review this time...I do so love the review
lottery.
| Assignee | ||
Updated•21 years ago
|
Attachment #156001 -
Attachment is obsolete: true
| Assignee | ||
Updated•21 years ago
|
Attachment #156219 -
Flags: review?(bugs)
| Assignee | ||
Updated•21 years ago
|
Attachment #156001 -
Flags: review?(firefox)
Comment 17•21 years ago
|
||
*** Bug 255762 has been marked as a duplicate of this bug. ***
Comment 18•21 years ago
|
||
Comment on attachment 156219 [details] [diff] [review]
Updated again
looks good, lets get this driven in
Attachment #156219 -
Flags: review?(bugs)
Attachment #156219 -
Flags: review+
Attachment #156219 -
Flags: approval-aviary?
Comment 19•21 years ago
|
||
Comment on attachment 156219 [details] [diff] [review]
Updated again
a=chofmann for the aviary branch.
Attachment #156219 -
Flags: approval-aviary? → approval-aviary+
Comment 20•21 years ago
|
||
Fix checked in. Just got CVS working again.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
| Assignee | ||
Updated•21 years ago
|
Target Milestone: --- → Firefox1.0beta
| Assignee | ||
Updated•21 years ago
|
Keywords: fixed-aviary1.0
Comment 21•21 years ago
|
||
I suppose I'm a bit late weighing in, but: Because "Web" is the short form of
"World Wide Web", a proper noun, standard English dictates the W be capitalized
in "the Web", "Web site", "Web page", etc.
As Bill Walsh recently wrote, "A web site is where flies go to die".
You need to log in
before you can comment on or make changes to this bug.
Description
•