249613 - Deleting an address book sets a |ldap_2.servers.XYZ.position = 0| preference, instead of removing it.

Status: VERIFIED WONTFIX

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a1) Gecko/20040520] (release) (W98SE)

This happens whether the |.position| pref. exists or not before the deletion.
The other |ldap_2.servers.XYZ.*| pref. are removed as expected.

Workaround:
Manually delete the remaining pref. (about:config or .js).

***

I guess that this is related to
{{ <http://lxr.mozilla.org/seamonkey/search?string=deleteAddressBooks>
deleteAddressBooks
/mailnews/addrbook/prefs/resources/content/pref-directory.js, line 436 --
addressbook.deleteAddressBooks(addressbookDS, parentArray, resourceArray);
/mailnews/addrbook/public/nsIAddressBook.idl, line 53 -- void
deleteAddressBooks(in nsIRDFDataSource aDS, in nsISupportsArray aParentDir, in
nsISupportsArray aResourceArray);
/mailnews/addrbook/resources/content/addressbook.js, line 565 --
top.addressbook.deleteAddressBooks(dirTree.database, parentArray, resourceArray);
/mailnews/addrbook/src/nsAddressBook.cpp, line 235 -- NS_IMETHODIMP
nsAddressBook::DeleteAddressBooks
/mailnews/extensions/palmsync/src/nsAbPalmSync.cpp, line 1024 --
return(ab->DeleteAddressBooks(ds, parentArray, selectedArray));
/mail/components/addrbook/content/addressbook.js, line 572 --
top.addressbook.deleteAddressBooks(dirTree.database, parentArray, resourceArray);
}}
but I don't see where the pref. is set :-(

CC bienvenu (based on his bug 239714 comments...)

Comment 1

[Serge Gautherie (:sgautherie)]

David:
You fixed related bug 239714 today;
would you have a fix for this one too ?

Comment 2

[David :Bienvenu]

Attachment: proposed fix

this should fix it for you.

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> Created an attachment (id=161303)
> proposed fix
> 
> this should fix it for you.

I have no compiler, then I can't test cpp files :-|

Matthias: Could you try to compile, and possibly test, this patch ? Thanks.
(Create a local a.b., delete it, check the (remaining) prefs: do it without,
then with, the patch.)

Comment 4

[Matthias Bockelkamp]

(In reply to comment #3)
> Matthias: Could you try to compile, and possibly test, this patch ? Thanks.
> (Create a local a.b., delete it, check the (remaining) prefs: do it without,
> then with, the patch.)

After compiling with the patch the behaviour is still the same (the .position=0
remains after deleting the address book).

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> (In reply to comment #3)
> > (Create a local a.b., delete it, check the (remaining) prefs: do it without,
> > then with, the patch.)
> 
> After compiling with the patch the behaviour is still the same (the .position=0
> remains after deleting the address book).

David:
Could you have another look at this ?

Comment 6

[Asa Dotzler [:asa]]

David, is this something that you can look into in time for 1.8a6?

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> David, is this something that you can look into in time for 1.8a6?

Asa:
David doesn't seem to be much available these days ... Is there someone else who
could help ?

Comment 8

[Mark Banner (:standard8)]

For anyone looking at this bug the reason it was implemented in the first case
seems to be due to bug 232429 - it's related to the palm sync code.

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #8)
> For anyone looking at this bug the reason it was implemented in the first case
> seems to be due to bug 232429 - it's related to the palm sync code.

David:
Should the current bug be resolved as WontFix ?
Or would there be another fix ?
Or is there a way to activate this behaviour for PalmSync users only ?

Comment 10

[David :Bienvenu]

yes, I think wontfix - I don't think it's worth inventing a new mechanism for palm sync.