249778 - Save Message dialog does not respond to command-d (Don't Save)

Status: RESOLVED DUPLICATE of bug 207510

(MailNews Core :: Composition, defect)

Description

[Not interested in Mozilla any more]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040616
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040616

All dialogs in other applications allow you to select the 'don't save' option by
clicking command-d. Mozilla does not.

Reproducible: Always
Steps to Reproduce:
1. Start a message and enter a to address and subject
2. Click the close box or hit Command-w
3. You will be asked 'Message not send. Do you want to save the in the Drafts
folder'.
4. Press Command-d

Actual Results:  
Nothing happens

Expected Results:  
The dialog should go away and the message should not be saved. The dialog should
respond as if the user had clicked the "Don't save" button.

Comment 1

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 2

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.

Comment 3

[Not interested in Mozilla any more]

This feature annoys me on a daily basis and should be fixed. Surely it can't be
that hard to fix.

Comment 4

[Mike Cowperthwaite]

Under Windows, Alt+D does activate the "Don't send" button.  Ctrl+D (which I gather is the equivalent to Mac's Cmd+D) doesn't.

Do other pushbuttons (either in the Mac generally, or in Mozilla) activate 
using Cmd+<letter>?

Comment 5

[Frankie]

Thanks for pointing me to this, Mike. It's been bugging me for a year, but not enough to Bugzilla it. 

Yes, other command keys work as expected in Mac Thunderbird (and presumably Suite). cmd-W is close window. If the message is in progress, you get the Save? dialog. cmd-S will save, cmd-. will cancel, but cmd-D does not work.

I really need to dust off my coding skills so I can fix some of these myself. I'm sure this one would be easy.

Comment 6

[Not interested in Mozilla any more]

Yes, I can confirm this. On the Mac Cmd-D allways operates the don't save button, appart from in SeaMonkey/Firefox/Thunderbird.

Comment 8

[Ken Kling]

Problem still is there in Mac TB 2 betas.  It's my main annoyance with TB.  

Comment 9

[Joseph Jackson]

I've been looking into the source code for this issue. It has lead me to the observation that a shortcut key *is* specified for both the "Don't Save" and "Save" buttons. It's just that the modifier is wrong on the Mac platform. The Control-D and Control-S keys will operate those buttons, but Mac users expect Command-D instead.

Here's the file that specifies the key labels. Note that Save and DontSave values both begin with an ampersand, indicating that a modifier key shortcut is requested.

toolkit/locales/en-US/chrome/global/commonDialogs.properties

I would like to see the Command key used instead but it's not clear to me what global impact that might have. Are there cases where the standard shortcuts like Command-C and Command-V (for cut and paste) would be re-assigned if the Mozilla apps changed all shortcuts from Control to the Command key? Does this go against the Mozilla philosophy of keeping shortcuts the same on all platforms? I don't know the right forum for asking these questions, but perhaps someone else interested in this bug report can get an authoritative answer.

Comment 10

[Not interested in Mozilla any more]

Mozilla seems to follow the standard for the platform but so it should be Command. Any app worth using will do what users expect. You will never get a mac user to use control for this feature, they wouldn't even think about trying. It should only be changed on this dialog (rather than any sweeping change all over as this is fine elsewhere (Command-c works for copy, not control).

Comment 11

[Frankie]

Well whaddayaknow. I'd never considered trying ctrl-D. The problem is that the other buttons work as expected: Cancel is cmd-. and Save (the blue highlighted button) is Enter, leaving only Don't Save as (apparently) un-shortcut.

Comment 12

[S Steiger]

I confirm this. Still there in TB RC1

Comment 13

[lukas-mozbugs]

Still there in 3.0 beta1. Please fix this, it is really annoying. The current behaviour is completely counter-intuitive for the average Mac user, especially as Thunderbird uses cmd for most of it's shortcuts (I didn't even know there *is* a shortcut for that, until I read about it on this page when I looked for bug reports about it).