249868 - Series pages do not validate

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Joel Peshkin]

Essence of problem is that script does not specify a type and a lot of <script>
and <noscript> stuff is between table rows.

To repeat this, hard-code a test userid and password into a validator url..


http://validator.w3.org/check?uri=http%3A%2F%2Fpeshkin.net%2Ftip%2Fchart.cgi%3FBugzilla_login%3Dyouraccount%40your.host%26Bugzilla_password%3Dyourpassword&charset=%28detect+automatically%29&doctype=%28detect+automatically%29&ss=1

   1.

      Line 76, column 7: required attribute "TYPE" not specified

      <script>

      The attribute given above is required for an element that you've used, but
you have omitted it. For instance, in most HTML and XHTML document types the
"type" attribute is required on the "script" element and the "alt" attribute is
required for the "img" element.

      Typical values for type are type="text/css" for <style> and
type="text/javascript" for <script>.

      &#9993;
   2.

      Line 284, column 17: document type does not allow element "NOSCRIPT" here;
missing one of "TH", "TD" start-tag

      <noscript><th></th></noscript>

      The mentioned element is not allowed to appear in the context in which
you've placed it; the other mentioned elements are the only ones that are both
allowed there and can contain the element mentioned. This might mean that you
need a containing element, or possibly that you've forgotten to close a previous
element.

      One possible cause for this message is that you have attempted to put a
block-level element (such as "<p>" or "<table>") inside an inline element (such
as "<a>", "<span>", or "<font>").

      &#9993;
   3.

      Line 284, column 21: document type does not allow element "TH" here

      <noscript><th></th></noscript>

      The element named above was found in a context where it is not allowed.
This could mean that you have incorrectly nested elements -- such as a "style"
element in the "body" section instead of inside "head" -- or two elements that
overlap (which is not allowed).

      One common cause for this error is the use of XHTML syntax in HTML
documents. Due to HTML's rules of implicitly closed elements, this error can
create cascading effects. For instance, using XHTML's "self-closing" tags for
"meta" and "link" in the "head" section of a HTML document may cause the parser
to infer the end of the "head" section and the beginning of the "body" section
(where "link" and "meta" are not allowed; hence the reported error).

      &#9993;
   4.

      Line 286, column 17: document type does not allow element "NOSCRIPT" here;
missing one of "TH", "TD" start-tag

      <noscript><th></th></noscript>

      &#9993;
   5.

      Line 286, column 21: document type does not allow element "TH" here

      <noscript><th></th></noscript>

      &#9993;
   6.

      Line 308, column 17: document type does not allow element "NOSCRIPT" here;
missing one of "TH", "TD" start-tag

      <noscript>

      &#9993;
   7.

      Line 309, column 13: document type does not allow element "TD" here

      <td>

      &#9993;
   8.

      Line 318, column 14: end tag for "SELECT" which is not finished

      </select>

      Most likely, You nested tags and closed them in the wrong order. For
example <p><em>...</p> is not acceptable, as <em> must be closed before <p>.
Acceptable nesting is: <p><em>...</em></p>

      Another possibility is that you used an element (e.g. 'ul') which requires
a child element (e.g. 'li') that you did not include. Hence the parent element
is "not finished", not complete.

      &#9993;
   9.

      Line 322, column 17: document type does not allow element "NOSCRIPT" here;
missing one of "TH", "TD" start-tag

      <noscript>

      &#9993;
  10.

      Line 323, column 13: document type does not allow element "TD" here

      <td>

      &#9993;
  11.

      Line 332, column 20: end tag for "SELECT" which is not finished

      </select>

      &#9993;

Comment 1

[Dave Miller [:justdave]]

I won't hold the RC for this, but HTML validation issues (with the exception of
bug 11901) will block the final release.

Comment 2

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 3

[Marc Schumann [:Wurblzap]]

Attachment: Patched patch

The previous patch had an error on it I obviously had not gotten rid of
before...

Comment 4

[Christian Reis]

Comment on attachment 156970 [details] [diff] [review]
Patched patch

I'm a bit concerned the empty cells will break things in certain browsers -- I
remember netscape did, and I suspect gecko might. Can you check for that?

Comment 5

[Marc Schumann [:Wurblzap]]

Seems to work with
o Firefox 0.9.3 (Mozilla/5.0 (Windows; U; Windows NT 5.0; de-DE; rv:1.7)
  Gecko/20040803 Firefox/0.9.3)
o Opera 7.23 (Opera/7.23 (Windows NT 5.0; U)  [de])
o IE 6 (Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0; .NET CLR 1.0.3705;
  .NET CLR 1.1.4322))

IE lets you select the dummy entry, but even so I haven't managed to fool the form.

Comment 6

[Christian Reis]

Comment on attachment 156970 [details] [diff] [review]
Patched patch

It would be nicer if we could omit the selects themselves and substitute them
for text saying that no options are available there -- that would also avoid
the x="" hack (you'd check for name/${sel.name}.size beforehand).

What do you think of that?

Comment 7

[Christian Reis]

Marc? Gerv, opinion?

Comment 8

[Marc Schumann [:Wurblzap]]

Hmm. With JavaScript enabled, the <select>s need to be created empty, and they
are filled as soon as the page is loaded. Can we find out server-side whether
JavaScript is enabled?

Even if we could, I'm not too fond of replacing the <select> with text. I think
an empty <select> is more intuitive. Maybe we could disable the <select>s at first?

Comment 9

[Marc Schumann [:Wurblzap]]

Attachment: No x hack; disabled select

Comment 10

[Gervase Markham [:gerv]]

Comment on attachment 157309 [details] [diff] [review]
No x hack; disabled select

I don't know if it still validates, but it doesn't seem to break anything, so
if validation is a requirement, then r=gerv.

Gerv

Comment 11

[Myk Melez [:myk] [@mykmelez]]

Thanks for the patch, Marc!

Checking in bztip/template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v 
<--  filterexceptions.pl
new revision: 1.24; previous revision: 1.23
done
Checking in bztip/template/en/default/reports/create-chart.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/create-chart.html.tmpl,v
 <--  create-chart.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in bztip/template/en/default/reports/series-common.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/series-common.html.tmpl,v
 <--  series-common.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in bztip/template/en/default/reports/series.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/series.html.tmpl,v
 <--  series.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in bz218/template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v 
<--  filterexceptions.pl
new revision: 1.16.2.2; previous revision: 1.16.2.1
done
Checking in bz218/template/en/default/reports/create-chart.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/create-chart.html.tmpl,v
 <--  create-chart.html.tmpl
new revision: 1.8.2.2; previous revision: 1.8.2.1
done
Checking in bz218/template/en/default/reports/series-common.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/series-common.html.tmpl,v
 <--  series-common.html.tmpl
new revision: 1.2.2.1; previous revision: 1.2
done
Checking in bz218/template/en/default/reports/series.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/series.html.tmpl,v
 <--  series.html.tmpl
new revision: 1.4.2.2; previous revision: 1.4.2.1
done