250043 - Bookmark sub-menu remains open after clicking on a Bookmark in the Bookmark menu if an attempt to drag & drop a Bookmark into it was cancelled.

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Michael Gibson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040626 Firefox/0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040626 Firefox/0.8

If the user attempts to move a Bookmark to a sub menu (folder) using drag & drop
and the drop down Bookmark menu, but instead cancels it by moving the mouse back
into the Bookmark menu and releasing the button, and then clicks on any bookmark
before the sub menu (folder) closes, the sub menu (folder) will stay open.

Reproducible: Always
Steps to Reproduce:
1. Create a Bookmark and a Folder.
2. Open the Bookmarks menu.
3. Click and hold on the Bookmark to begin the drag & drop procedure.
4. Drag the Bookmark into the created Folder, but do not drop it there.  This
will open a sub-menu containing the Bookmarks, if any, in the Folder.
5. Drag the Bookmark back to its original location.
6. Quickly drop the Bookmark and click any Bookmark before the Folder sub-menu
closes.
Actual Results:  
The Folder sub-menu will remain open even though the Bookmarks menu is closed.

Expected Results:  
The Folder sub-menu should have closed with the rest of the Bookmark menu.

This occurs with both the Default theme and the Luna theme.

It is (relatively easily) avoided by waiting until the Folder menu closes before
clicking on a Bookmark.

Comment 1

[Greg Campbell]

confirmed WinXP
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040703
Firefox/0.9.0+

using Qute, so this likely isn't theme-dependent.

When the floating submenu remains, it is impossible to minimize the window.

Comment 2

[shadytrees]

Can also confirm. Using Orbit Something, so more evidence it's not theme
specific. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040624
Firefox/0.9

Comment 3

[Barnabas P. Crocker]

There seems to be a general problem with the Bookmark-Folder Sub-Menus. Try this
(Firefox 0.10 WinXP): 

1. Click on Bookmarks
2. Click on any Bookmark with the left mouse butten and hold
3. While clicking with the left button click right button
4. Page opens, sub menu remains

Seems to be the same bug. 

Comment 4

[ffolkes]

Barnabas P. Crocker's comment is still valid using RC2. Why is this listed as
unconfirmed? Granted, it's a minor bug, but still, a bug none the less.

Comment 5

[Barnabas P. Crocker]

@ #3 - Still my discovery still works on 1.0. Should I open a new bug?

Comment 6

[Martijn Wargers (dead)]

Is this still an issue in current trunk build?

Comment 7

[Cass Scuro]

(In reply to comment #6)
> Is this still an issue in current trunk build?

I still can consistently reproduce this following the steps in comment #1 (with
trunk, Windows NT 5.1, rv:1.8b4, 2005081006), but I believe (not sure) that the
delay that submenus remain open may have been reduced, so you have to click
quicker to get the submenu to stay floating.

Comment 8

[Martijn Wargers (dead)]

Ok, I can reproduce it now, but after step 6, I need to also hover over the
"File", "Edit", "View", "Go", "Tools" or "Help" to see the submenu not go away.

Comment 9

[Cass Scuro]

Another similar case that I just figured out how to reproduce:
Using the bookmark menu (not sidebar, toolbar or linkbar)

1. Have a folder with at least one bookmark in it, and have two bookmarks not in
any folder.
2. Drag one of the bookmarks into the folder (by dragging over the folder and
under the existing bookmarks in the folder- do not drop it on the folder name,
but over by the other bookmark).
3. Without moving over the folder name, move to the bookmark that is not in any
folder and left click.  The page will open, but the folder contents will stay
displayed.

None of this requires fast motion, the only requirement is not crossing the
folder name once you have dropped the bookmark into the folder.
This happens for me on win, with branch  1.8b4 2005082206.

Also, an observation is that if you have an empty folder, you cannot drop a
bookmark on the area that says (empty) and therefore cannot make this menu
happen.  Being unable to drop on the (empty) looks like a separate bug.  (Note,
you can put a bookmark in an empty folder by dropping it on the folder name.)

Comment 10

[Martijn Wargers (dead)]

Seems to me that the onDragCloseTarget function has to be called in the onDrop
function:
http://lxr.mozilla.org/seamonkey/source/browser/components/bookmarks/content/bookmarksMenu.js#608

Comment 11

[thabenksta]

I have found a similar bug that is most likely related.

I have a live bookmark to an RSS feed setup on my bookmark toolbar.

1. Click on the live bookmark, displaying the RSS items.
2. Right-click on the item displaying the context menu.
3. Move the cursor to the next live bookmark on the toolbar.

Result:
The context menu remains, even after clicking in other areas.  The only way I
found to get rid of it is to click on the menu.

Comment 12

[Andre Sihera]

I can confirm the behaviour in Comment #11. Context menus when opening
bookmarks get stuck open if you open the Context menu when hovering over a
bookmark, then, without selecting an option, you move the mouse to the "File"
menu (for example). The Context menu remains open. Clicking on the page
background will get rid of it though.

Interestingly enough, while the context menu is still open, if you then click on
the Bookmarks menu again and open the Bookmarks sub-menus so that you're
hovering over an item, and if you are able move to the stuck context menu
without closing the bookmarks menu (because they overlap), then selecting an
item from the context menu does actually work correctly on the currently
"hovering" item.

Interesting...

Comment 13

[Nikola Kocić]

(In reply to comment #12)
> I can confirm the behaviour in Comment #11. Context menus when opening
> bookmarks get stuck open if you open the Context menu when hovering over a
> bookmark, then, without selecting an option, you move the mouse to the "File"
> menu (for example). The Context menu remains open. Clicking on the page
> background will get rid of it though.
> 
> Interestingly enough, while the context menu is still open, if you then click on
> the Bookmarks menu again and open the Bookmarks sub-menus so that you're
> hovering over an item, and if you are able move to the stuck context menu
> without closing the bookmarks menu (because they overlap), then selecting an
> item from the context menu does actually work correctly on the currently
> "hovering" item.
> 
> Interesting...
> 

Yes, i see this too

Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8b5) Gecko/20051015
Firefox/1.4.1 ID:2005101504

Comment 14

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change

Comment 15

[Toby]

Attachment: Steps to reproduce comment 11 and screenshot

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a4pre) Gecko/20070406 Minefield/3.0a4pre ID:2007040605 [cairo]

Today I encountered the bug described by comment 11. I can reproduce the original bug issue too. 
The attachment should hopefully illustrate visually how to reproduce.

Comment 16

[vesa.rankaviita]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.2) Gecko/20070222 SeaMonkey/1.1.1

I doubt that this helps anyone, but bug described in Comment #9 still exists in new version of Seamonkey

Comment 17

[[:Aleksej]]

STR a similar thing on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a5pre) Gecko/20070522 Minefield/3.0a5pre :
1. Drag the favicon from URL bar to the Bookmarks menu, so it opens (don't release)
2. Drag it to an toolbar space (e.g. on the menu toolbar or the bookmarks toolbar)

Now the menu is still open, is real, but is not focused. You can switch to another workspace, do anything with your keyboard, as long as you don't click in Firefox. The menu disappears if you click an item in it, or focus it (for example, with Alt-B).

Comment 18

[Tracy Walker [:tracy]]

> Result:
> The context menu remains, even after clicking in other areas.  The only way I
> found to get rid of it is to click on the menu.

this can be reproduced with an context clickable menu item  ie Bookmarks.  a workaround, or at least a way to get rid the "sticky" context menu is to context click somewhere else. On the toolbar works fine. Then click away from there to finally have all context menus gone.

Comment 19

[mmortal03]

I do not see this anymore. It actually isn't even reproducible from my perspective, because the sub-menu doesn't say open once you move back away from it, before you can even get to the point where you could release the bookmark and click another one before it closes. I do see a very similar issue, Bug 225434, where the folder button remains depressed on the Bookmarks Toolbar, following similar steps, but not anything where the sub menu remains open.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008042705 Minefield/3.0pre ID:2008042705

Comment 20

[Marco Bonardo [:mak]]

i tried some of the paths in this bug and i cannot reproduce, if anyone has better steps to see a problematic path with drag&drop and menu open/close, please file it as a stand alone bug, having many different issues reported in the same bug makes it too crowded and confused to test it.

That said, this report was about a bookmark submenu staying open, not about a context menu, if there's still an issue with a context menu should be filed separately as an issue with a context menu.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20090217 Shiretoko/3.1b3pre