25006 - Patching Linux binary results in unrunnable file

Status: RESOLVED WONTFIX

(Core Graveyard :: Installer: XPInstall Engine, defect, P5)

Description

[Jimmy Lee]

Build: 12/24/99 (LINUX)

1. From http://jimbob/trigger2.html, enter and trigger 
   http://jimbob/jars/f_addunixpatch.xpi
2. Then trigger http://jimbob/jars/f_unixpatch.xpi to apply the patch
3. Change to the /unixpatch subdirectory that is created to check the patched
   file

////////////////////////////////////////////////////////////////////////////////
// f_addunixpatch.js
// 
// Acceptance test
// 	• Adds a component to set up Patch() from f_unixpatch.xpi
// 	• This test investigates patching a unix binary file
//
// ~ XPInstall QA
//   January 24, 2000
//
////////////////////////////////////////////////////////////////////////////////

var regName = "f_unixpatch";
var jarSrc = "test_exe";
var vi = "1.1.1.1";

startInstall("Functional: f_addunixpatch", "f_unixpatch", vi, 0);
f = getFolder("Program", "unixpatch");
err = addFile(regName, vi, jarSrc, f, jarSrc, true);
logComment("addFile returns = " + err);

////////////////////////////////////////////////////////////////////////////////
// f_unixpatch.js
// 
// Functional test
// 	• Patches a binary file test_exe; the new file will output text to the 
//        screen x times
//
//        test_exe x
//
// Dependency
// 	• f_addunixpatch.xpi should be triggered to set up target file for 
//        patching
//
// ~ XPInstall QA
//   January 24, 2000
//
////////////////////////////////////////////////////////////////////////////////

var regName = "f_unixpatch";
var jarSrc = "test_exe_param.gdf";
var vi = "2.2.2.2";

startInstall("Functional: f_unixpatch", "f_unixpatch", vi, 0);
f = getFolder("Program", "unixpatch");
err = patch(regName, vi, jarSrc, f, "test_exe", true);
logComment("patch returns= " + err);

RESULT:
The Version Registry updates properly.  The Install.log appears accurate.  The 
patched binary file now has permissions of -rw-r--r--.  Manually changing the 
permissions to restore x allows for executing the file as expected.

EXPECTED RESULT:
The file permissions should not lose the executable permission.  The original 
file installed from f_addunixpatch.xpi has permissions -rwxr-xr-x.  The 
permissions of the gdf patch from f_unixpatch.xpi are -rwxrwxrwx.

Comment 1

[leger]

Moving [PP] to pp in keyword field.  and adding patch keyword

Comment 2

[Cathleen]

we should make the resulting file has the same permission of the original file.

marking as REMIND.

Comment 3

[Jimmy Lee]

I am proposing that REMIND be removed for this bug.  The problem is not merely a 
matter of permissions.  The patch fails, and I cannot confirm if it is directly 
related to permissions or not.  Sorry for the lack of clarification.

For the case originally described, manually restoring permissions will result in 
dumping core if the binary is executed.  There is no known workaround if this 
bug is not fixed.

Comment 4

[Cathleen]

see if we can fix for PR3

Comment 5

[Daniel Veditz [:dveditz]]

Parcelling out Cathleen's bugs

Comment 6

[Samir Gehani]

No "patch" has been submitted for this bug.  It is about the "patching" feature
in the XPInstall engine.  Removing erroneous inclusion of "patch" keyword.

Comment 7

[David Epstein]

nominating for nsbeta3 by QA. Binary patching still crashes. This is the only 
patching solution available for linux binaries.

Comment 8

[Daniel Veditz [:dveditz]]

nsbeta3-: Patching is not a priority for this release. Changing the summary to 
something more vague due to comments that the permissions is not the only 
problem with the patch.

Comment 9

[Daniel Veditz [:dveditz]]

Resetting target field for missed milestones

Comment 10

[Daniel Veditz [:dveditz]]

nominating nsbeta1, removing obsolete nsbeta3 keyword and CC's

Comment 11

[Daniel Veditz [:dveditz]]

I think I have the other patching bugs at the moment.

Comment 12

[Daniel Veditz [:dveditz]]

Moz 0.9 tasks

Comment 13

[Jimmy Lee]

I recommend nsbranch- for this patching bug.

Comment 14

[Marcia Knous [:marcia]]

marking nsbranch- per PDT triage

Comment 15

[Jimmy Lee]

nsbeta1-.  No patching this time around.

Comment 16

[Daniel Veditz [:dveditz]]

The xpinstall script engine has been removed from the trunk, bugs in it are obsolete.