250072 - Feature request: Switching fields in chatzilla

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Aaron Graves]

For users without a mouse (which don't exist anymore), or those that like to use
keyboard, or those that participated in the bug day on 6 Jul (unplug your
mouse!), it's impossible to select links in the output by using keyboard only.
Tab has a different purpose in the input. Perhaps another key combination to
send focus to the output, so that someone can select a link, or other text?
Please :)

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

F6 works :)
as long as you have less than 6 tabs open, at least.

ctrl+tab may also work (I could not verify, as my window manager catches taht...)

Comment 2

[Aaron Graves]

I find F6 will only bring focus to the user list in my chatzilla. However, I
have found this:

Press Shift+F6, and then tab. And now you can tab through the links. It looks
like I got overzealous with this bug filing *blushes*

Comment 3

[James Ross]

(In reply to comment #1)
> ctrl+tab may also work (I could not verify, as my window manager catches taht...)

Ctrl-Tab, and Ctrl-Shift-Tab rotate view, like any other tabbed screen.

(In reply to comment #2)
> Press Shift+F6, and then tab. And now you can tab through the links.

It also looks like Shift-F6 instantly crashes my Mozilla. :(

Comment 4

[Aaron Graves]

If Shift+F6 crashes Mozilla... maybe a new keyboard shortcut to focus on the
output is needed? One that won't crash Mozilla? lol

Comment 5

[Robert Ginda]

ESC can already be used to focus the input box... maybe it can focus
the output window if the input box already has focus.

Comment 6

[James Ross]

(In reply to comment #5)
> ESC can already be used to focus the input box... maybe it can focus
> the output window if the input box already has focus.

No, I like how it is a /guarentee/ that I'm in the input box. :)

Comment 7

[Robert Ginda]

ya, you've got a point.  I often whack ESC a few times, to be sure it heard me.

Comment 8

[Aaron Graves]

But do you guys see how this could be useful? Especially you, Silver, who's
Mozilla crashed with the Shift+F6 combination?

Comment 9

[James Ross]

(In reply to comment #8)
> But do you guys see how this could be useful? Especially you, Silver, who's
> Mozilla crashed with the Shift+F6 combination?

Personally, it would be no use to me, as I use the mouse for any
link-clicking/copying, but I know other people don't.

I think Shift-F6 is probably good enough for this, though obviously I need to
work out why it crashed here. :)  (probably XUL tried to focus something that
didn't exist, it's good at that)

Comment 10

[James Ross]

When bug 265847 is fixed, F6 and Shift-F6 should work well enough for this bug
to be resolved.

Comment 11

[Glen Mailer]

Attachment: prevent default action on function keys

This patch overrides the default action on any regular function key presses,
but allows the default action if any modifier key is held, hence shift+F6 will
still work.

Also fixes ctrl+pgup/dn

Comment 12

[James Ross]

Comment on attachment 187412 [details] [diff] [review]
prevent default action on function keys

r=silver

Comment 13

[James Ross]

Comment on attachment 187412 [details] [diff] [review]
prevent default action on function keys

Checked in. This obviously does not fix this bug, but it does help stop
mutliple things happening at once for the F keys.

Comment 14

[Glen Mailer]

Attachment: Prevent default action regardless of tab existing

After a testing on a new build it occured to me that the inconsistent actions
from the shortcut keys if the tabs didnt actually exist was a bit confusing, so
i have attached a patch that would always prevent the default event if no
modifier is held.

As for the actual bug, i would say that this patch does fix it, as ctrl+F6 and
shift+F6 will now always switch focus to the output window, while F6 alone will
not (unless the tab doesnt exist, which is addressed by patch #2).

I'm not sure which behaviour should be preferred, but when one is picked i
reckon this bug can be resolved fixed.

Comment 15

[Glen Mailer]

Comment on attachment 188209 [details] [diff] [review]
Prevent default action regardless of tab existing

requesting review for this patch, still unsure as of yet whether its inclusion is a good idea or a bad one

Comment 16

[James Ross]

Comment on attachment 188209 [details] [diff] [review]
Prevent default action regardless of tab existing

r=silver

Comment 17

[James Ross]

Checked in --> FIXED.