250177 - Filepicker needs accesskey for dirTextInputLabel

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Martijn Ras]

The filepicker is initialized using the values of textInput.label and
textInput.accesskey from filepicker.dtd:
<!ENTITY textInput.label        "File name:">
<!ENTITY textInput.accesskey        "n">

In case it is used to pick a directory instead of a file, the filepicker replace
s the value of textInput.label with the value of dirTextInputLabel from
filepicker.properties:
dirTextInputLabel=Directory name:

After translation this may mean that the accesskey becomes invalid when using
the filepicker to select a directory:
<!ENTITY textInput.label        "Bestandsnaam:">
<!ENTITY textInput.accesskey        "B">
dirTextInputLabel=Mapnaam:

I'd like to have an string added to the languagepack to be able to specify the
accesskey to be used with the dirTextInputLabel.

--- filepicker.original.properties      Wed Jul  7 15:24:47 2004
+++ filepicker.properties       Wed Jul  7 15:25:00 2004
@@ -17,0 +18 @@
+accesskeydirTextInputLabel=n

--- filepicker.original.js      Wed Jul  7 14:30:23 2004
+++ filepicker.js       Wed Jul  7 14:32:47 2004
@@ -90,0 +91 @@
+textInputLabel.setAttribute('accesskey',gFilePickerBundle.getString("accesskeydirTextInputLabel"));

Comment 1

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Comment 2

[[e-mail]]

Comment on attachment 231652 [details] [diff] [review]
Patch rev. 1

>     textInputLabel.value = gFilePickerBundle.getString("dirTextInputLabel");
>+    textInputLabel.setAttribute('accesskey', gFilePickerBundle.getString("dirTextInputAccesskey"));
Nit: use the .accessKey property. r+sr=me with this fixed.

Comment 3

[Mats Palmgren (inactive)]

Attachment: With Neil's comments, checked in

Checked in to trunk at 2006-08-05 20:11 PDT.

-> FIXED

Comment 4

[[e-mail]]

Mats, I checked in the XPFE part of the patch to the branch for SeaMonkey 1.1