250265 - taint issues with vote fields when editing products

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[GavinS]

votesperuser, maxvotesperbug and votestoconfirm all have taint problems

Comment 1

[GavinS]

Attachment: detaint (and validate) the vote-related parameters when editting products

Comment 2

[Vlad Dascalu]

Comment on attachment 152554 [details] [diff] [review]
detaint (and validate) the vote-related parameters when editting products

detaint_natural doesn't return true for negative integers.

Therefore, "if $number < 0", then "!detaint_natural($number)" will be certainly
true. This can be used in order to remove the redundant checks in the patch.

Comment 3

[Vlad Dascalu]

Attachment: GavinS's patch with optimised if conditions

Comment 4

[Vlad Dascalu]

Since we're short on time, if anybody is available for review feel free to dig
in. :)

Comment 5

[Joel Peshkin]

Comment on attachment 152617 [details] [diff] [review]
GavinS's patch with optimised if conditions

r=joel

Comment 6

[Vlad Dascalu]

Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.53; previous revision: 1.52
done