250278 - move EditorResetFontAndColorAttributes() out of editor.js and into MsgComposeCommands.js

Status: RESOLVED EXPIRED

(SeaMonkey :: Composer, defect)

Description

[(not reading, please use [e-mail] instead)]

move EditorResetFontAndColorAttributes() out of editor.js and into
MsgComposeCommands.js

from http://lxr.mozilla.org/mozilla/search?string=EditorResetFontAndColorAttrib

// This method is only called by Message composer when recycling a compose window
function EditorResetFontAndColorAttributes()
{
...
}

thanks to neil for pointing this out.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Patch

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Comment on attachment 153191 [details] [diff] [review]
Patch

Sorry, had a bad merge (created the patch before Seth landed 1.228)

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Patch, V2 (cleaned up additional comments, too)

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 153216 [details] [diff] [review]
Patch, V2 (cleaned up additional comments, too)

hammer, don't forget that this is code is called from a couple places
(seamonkey mail and tbird) and it also exists in mozilla/composer (daniel's nvu
html editor)

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Right, I saw the notice on Tinderbox:

Do not break Firefox, Thunderbird or Camino! You should make sure that API
changes are not going to break them before checking in. This is a new
requirement. By checking in you are also on the hook for Firefox and Thunderbird
and if there is bustage you will be required to fix it. Make sure you search in
mozilla/browser, mozilla/toolkit, mozilla/mail and mozilla/camino when making
API changes. Please contact [e-mail] if you have any questions.

My question is: do I really have to pull all those trees, or can the owners of
each product sync up with the Seamonkey change?

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

-> back to defaults

Comment 7

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 8

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420