250322 - nsLDAPSyncQuery::GetQueryResults can return null + NS_OK for OOM

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect)

Description

[timeless]

527     if (!mResults.IsEmpty())
528         *_retval = ToNewUnicode(mResults);
529     return NS_OK;

I'd file this bug as unconfirmed, but it seems that i can't. Given that some
code in this function is willing to return error conditions, i think this should
return NS_ERROR_OUT_OF_MEMORY if ToNewUnicode fails.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: first try

patch

Comment 2

[David :Bienvenu]

Comment on attachment 164241 [details] [diff] [review]
first try

switching review request to dmose

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 164241 [details] [diff] [review]
first try

>Index: nsLDAPSyncQuery.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/extensions/pref/autoconfig/src/nsLDAPSyncQuery.cpp,v
>retrieving revision 1.12
>diff -u -p -r1.12 nsLDAPSyncQuery.cpp
>--- nsLDAPSyncQuery.cpp	17 Sep 2004 13:03:32 -0000	1.12
>+++ nsLDAPSyncQuery.cpp	1 Nov 2004 23:26:39 -0000
>@@ -452,7 +452,7 @@ NS_IMETHODIMP nsLDAPSyncQuery::GetQueryR
>                                                PRUint32 aProtocolVersion,
>                                                PRUnichar **_retval)
> {
>-    nsresult rv;
>+    nsresult rv = NS_OK;

This is unnecessary, because rv will be immediately set by the call to
do_GetService().

Fix this, and you've got r=dmose.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch nr.2

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 167350 [details] [diff] [review]
patch nr.2

r=dmose

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

dmose: could You check this in, please?

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

ouch, timless checked it in at 2004-12-01 02:32.