25046 - html:label doesn't work

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Alec Flett]

at least in XUL, if I have a html:label for an html:input element, the label
doesn't activate the input.

e.g. 
<html:input type="checkbox" id="baby"><html:label for="baby">Click me
baby!</html:label>

Comment 1

[karnaze (gone)]

Reassigning to Rod.

Comment 2

[rods (gone)]

Chris, the checkin I mentioned doesn't effect this part of it. I am reassigning 
this to you.

Basically, as we discussed a XULDocument should probably implement 
nsIDOMHTMLDocument.

Comment 3

[Alec Flett]

meant to add ben goodger to the CC here, he's looking for this too

Comment 4

[Chris Waterson]

The problem is that the <html:label> code is expecting to be able to query the
document to an nsIDOMHTLMDocument. The way I see it we have three choices.

1. Support nsIDOMHTMLDocument in nsXULDocument. This would add a fair number of
unimplemented methods to the XUL document.

2. Hack <html:label> to QI() for nsIDOMXULDocument if the QI() to
nsIDOMHTMLElement fails. This would embed knowledge about XUL into HTML.

3. Add GetElemenyById() to nsIDocument. This would make <html:label> elements
work in plain old XML, also.

I favor doing either (1) or (3). Maybe (3) more than (1), now. vidur, hyatt:
what say you?

Comment 5

[David Hyatt]

I like (3).  I know I did (2) in at least one place, though, unless somebody 
removed it.  I remember it having to do with labels.

I do not like the idea of having XUL doc implement nsIDOMHTMLDocument, unless of 
course this is what's going to happen for XML documents with HTML markup anyway 
(I don't know of a decision in this regard yet).  I would think that the root 
tag's namespace would have something to do with which DOM document interface was 
chosen (e.g., XUL vs. HTML vs. some other ML), and so it doesn't seem like a XUL 
document should be implementing the HTML document interface.

I vote for (3).

Comment 6

[ckritzer (gone)]

Setting severity to critical

Comment 7

[ckritzer (gone)]

Adding beta1 keyword

Comment 8

[Alec Flett]

this magically started working today!
thanks, whoever did it :)

Comment 9

[ckritzer (gone)]

Alec, is this working in your local tree?  'Cuz I'm still seeing it on the
following platforms with today's commercial build:
- Linux6 2000-02-01-10 Commercial build
- Win98 2000-02-01-08 Commercial build
- MacOS86 2000-02-01-09 Commercial build

Comment 10

[Alec Flett]

works for me on linux and windows with today's build.

Comment 11

[ckritzer (gone)]

Either a) my testcase is crackers; b) this got broken again; or c) something
else got broken.

In the testcase below (also added as an attachment), I have two variations of
the label/checkbox thing.  In the first, the 'Click me baby' text shows up, but
clicking the text does not (de)select the checkbox.  In the second, the 'Click
me again baby' text does not show up (and is not clickable).

Alec, do I have an 'bad' testcase, is the build broken, or is it something else?

Reopening bug.

<?xml version="1.0"?>

<window xmlns:html="http://www.w3.org/TR/REC-html40"
 xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">

<html:form method="post" action="">
<html:input type="checkbox" id="baby"/>
<html:label for="baby">
Click me baby!
</html:label>

<html:input type="checkbox" id="againbaby">
<html:label for="againbaby">
Click me again baby!
</html:label>
</html:input>
</html:form>
</window>

Comment 12

[ckritzer (gone)]

Attachment: Testcase

Comment 13

[leger]

Putting on PDT+ radar for beta1.

Comment 14

[Chris Waterson]

So I just downloaded this test case. The first label seem to be working fine. 
Are you sure that your webserver is serving up "text/xul" as the MIME type for 
XUL files? (I noticed that, in the bug, you didn't add the test case as 
"text/xul".)

The second label isn't showing up, but my guess is that the XUL content sink 
doesn't do the "fixup" that the HTML sink does: you've put the <label> *inside* 
the <input>.

Marking fixed.

Comment 15

[ckritzer (gone)]

I'm 99% sure my server is set up to serve xul...I have other .xul files in the
http://voodoolady/bugzilla/ directory that appear to load fine.  Chris, could
you show me this (or any other like-kind) testcase working on your system? I'll
update the testcase and upload it as a text/xul file...

Comment 16

[ckritzer (gone)]

Okay.  I'm a complete buckethead.  I set the extension as xml instead of xul.
Duh-uh!

Marking VERIFIED FIXED on:
- Linux6 2000-02-21-08 Commercial build
- MacOS9 2000-02-21-08 Commercial build
- Win98 2000-02-21-08 Commercial build