250551 - history sidebar: after deleting items, empty "folders" do not vanish before re-opening the history sidebar

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Norbert]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040707 Firefox/0.9.2

- open the history sidebar:
There the items are grouped into "virtual folders", for example "Today".

- select all items for example in "Today", but do not select the folder itself

- press DEL:
The folder ("Today") still is shown, also it's empty.

- close and re-open the history sidebar:
Now the folder has vanished.



Solution:
Such folders should vanish _directly_ after having deleted all their content! 

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Ryan Polk (Quark)]

Fo View By Date and Site I see this when deleting a site's history without
selecting the folder.

For View By Date, this WFM (The folder disappears right away, though it's
terribly slow deleting all those items).

I don't think the fix for this would be worth the extra code, though.  Decision
from the devs?

Comment 2

[Mike Connor [:mconnor]]

no, its a visual polish issue.  Its pretty trivial though.

Comment 3

[Ihar 'Philips' Filipau]

> no, its a visual polish issue.

It's not. It's major regression issue. On my system for some time I had history expiration set to 999 days. 

Much later on I have spent lots of time trying to find why Firefox freezes completely when I browse main menu: yes, Firefox to display few top records of history reads the complete file in. If file is very large it take many seconds - in my case I started investigating when freezes reached 10-15 seconds.

From developer POV, that's not completely clear that to display 10 lines in menu, Firefox reads in all the megabytes of history I have accumulated since installation time.

> Its pretty trivial though.

I hope it is. I'd love to have that fixed in Ff/2.0

Comment 4

[Ihar 'Philips' Filipau]

> It's major regression issue.

Uhm... I meant there "Firefox inability to handle large amount history information".

Or shall I file bug for "History" menu handling separately?

Comment 5

[Marco Bonardo [:mak]]

this should not happen anymore with Places, those are managed through a query.