25081 - linked bugs have absolute path in bug_form.pl

Status: RESOLVED WONTFIX

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Rob Baham]

We have bugzilla v2.8 running on Redhat 6.1.

The cgi and perl files are in the cgi-bin directory and the html files are in 
the html direcotry.  When you view a bug (with show_bug.cgi/bug_form.pl) and it 
has a link to another bug, it uses the base url instead of a relative path like 
all the other references to show_bug.cgi.  I changed lines 93 and 98 of 
bug_form.pl to fix it.

This is line 93 before and after
$item = qq{<A HREF="${base}show_bug.cgi?id=$num">$item</A>};
$item = qq{<A HREF="show_bug.cgi?id=$num">$item</A>};

This is the change in the link.
http://domain/show_bug.cgi?id=41
http://domain/cgi-bin/show_bug.cgi?id=41

If you have any questions, let me know.

Comment 1

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 2

[Gervase Markham [:gerv]]

This bug has not been touched for more than nine months. In most cases, that 
means it has "slipped through the net". Please could the owner take a moment to 
add a comment to the bug with current status, and/or close it.

Thank you :-)

Gerv

Comment 3

[Matthew Tuck [:CodeMachine]]

Not sure I know what's you mean here.  Are you saying it fails when you have the
bugzilla scripts in a subdirectory on your web server?

Comment 4

[Dave Miller [:justdave]]

I know debian is trying to pull this trick on us now, too...

I'm not sure I see the reasoning behind splitting up all the files like this.  If 
all of the files that belong to the application are together in one place it 
makes it much easier to do things like running more than one copy of Bugzilla on 
the same machine (which is done a lot for testing purposes, 
landfill.tequilarista.org is a good example).  If you split these files up and 
put them in "standard" places, it a) breaks the application in subtle ways, like 
you noted, and b) makes it impossible to run multiple copies on the same machine, 
and c) causes potential conflicts with any other application that happens to 
reuse the same filename as any of the other files in Bugzilla...

Comment 5

[Andreas Franke (gone)]

I think what this bug is saying is that relative URLs should be preferred over
absolute (urlbase-prefixed) URLs whenever one of the cgi scripts generates a
link to the same cgi script, or to another bugzilla cgi script of the same
installation. I think it's a good idea. And it's easy to fix.

Currently bug_form.pl has this line:
   <TD ALIGN=RIGHT><B>Bug#:</B></TD><TD><A HREF=\"" . Param('urlbase') .
"show_bug.cgi?id=$bug{'bug_id'}\">$bug{'bug_id'}</A></TD>

Comment 6

[Andreas Franke (gone)]

Reassigning to default owner.

Comment 7

[Gervase Markham [:gerv]]

bug_form.pl is like that because you can then drag the link places, or bookmark
it, and the right thing happens. I _know_ we changed it for a reason - there's a
bug on it somewhere.

Gerv

Comment 8

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 9

[Gervase Markham [:gerv]]

This is WONTFIX - we made it use the base URL by design.

Gerv

Comment 10

[Dave Miller [:justdave]]

clearing milestone in INVALID/WONTFIX/DUPLICATE/WORKSFORME so they'll show up as
untriaged if they get reopened.