250862 - browser accepts dragged javascript: links (same-origin security hole)

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Jesse Ruderman]

Firefox accepts drags of javascript: links, allowing same-origin violations. 
Exploiting this hole requires getting the user to cooperate with instructions,
but does not require the user to do anything likely to make them suspicious.

I think Seamonkey has the same hole.

Combined with 250725 (Drag-and-dropped link skips CheckLoadURI), this
same-origin hole becomes an arbitrary code execution hole.

Comment 1

[Jesse Ruderman]

Attachment: demo for firefox

This demo works in Firefox and Mozilla, but it works better in Firefox.

Comment 2

[Jesse Ruderman]

Mike, this should block Mozilla 1.7.2.

Comment 3

[Daniel Veditz [:dveditz]]

-> Browser product so we can make it block more releases

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

+ing for dveditz to look at. 

Comment 5

[Daniel Veditz [:dveditz]]

Why do we allow privileged chrome inside a browser control? A few things
(about:config, about:plugins) would have to be moved into a chrome windows of
their own if we did that, but might be way safer in the long run.

Is javascript: the only scheme that isn't a complete replacement document?

Comment 6

[Jesse Ruderman]

We should also block data: URLs here, since like javascript: URLs, they inherit
their security context from the previous page.  (The fact that they can also act
as replacement URLs caused both Mozilla and IE to be vulnerable to bug 88167.)

Comment 7

[chris hofmann]

dan any updates on when a patche will be ready for this?

Comment 8

[georgi - hopefully not receiving bugspam]

why not disallow dragging into location bar if the protocol or the begining of
the URL is not "http" or "https" ?

i don't see any functional advantage of dragging into location bar compared to
clicking or middle clicking.

Comment 9

[georgi - hopefully not receiving bugspam]

sorry, didn't see the demo.

obviously the problem is not the location bar.

Comment 10

[Johnny Stenback (:jst)]

Attachment: Prevent dropping javascript: and data: URLs into firefox.

Comment 11

[Johnny Stenback (:jst)]

Attachment: Same thing for both Firefox and SeaMonkey

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 156550 [details] [diff] [review]
Same thing for both Firefox and SeaMonkey

sr=dveditz

Comment 13

[Daniel Veditz [:dveditz]]

I checked the other onDrops in the codebase (except calendar) and everything
else javascript urls are either already rejected or harmless (e.g. setting your
home page to a js url).

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 156550 [details] [diff] [review]
Same thing for both Firefox and SeaMonkey

a=asa for branch landings.

Comment 15

[georgi - hopefully not receiving bugspam]

looks like with the patch dragging "file" and "chrome" urls still may work which
may lead to trouble.

why not use a safe whitelist?

Comment 16

[Johnny Stenback (:jst)]

We decided against blocking chrome for now, we'll need to investigate the
results of blocking that more before flipping the switch. Bug 250725 is for
tracking that part, but that, in combination with this, is really bad, thus the
fix for this to start with.

Comment 17

[Johnny Stenback (:jst)]

Fixed on trunk, aviary, and 1.7 branches.

Comment 18

[Johnny Stenback (:jst)]

Fixed on the 1.7.2 branch now too.

Comment 19

[Asa Dotzler [:asa]]

Verified with Firefox 0.10 and Mozilla 1.7.3 on windows XP

Comment 20

[Tracy Walker [:tracy]]

verified windows 1.7.5 12/15

Comment 21

[Sylvain Pasche]

What about images in data: URL's?

It could be useful to allow these, as right now there's a little incoherence: you can drag file: or http: based images but not data: ones.